fix(core): adopt latest changes for user menu #13518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MariaIDineva
approved these changes
Oct 7, 2025
InnaAtanasova
force-pushed
the
feat/user-menu-latest-changes
branch
2 times, most recently
from
b275a94 to
6b3ec52
Compare
InnaAtanasova
force-pushed
the
feat/user-menu-latest-changes
branch
from
6b3ec52 to
51be302
Compare
| @Input() | ||
| @HostBinding('class.fd-list__title--wrap') | ||
| wrap = false; | ||
| wrap = input(false, { transform: booleanAttribute }); |
There was a problem hiding this comment.
So I know you're just updating this to an input signal. And I know wrap defaults to false and doesn't apply a class. But the default behavior is to wrap. Changing the value of this input doesn't have any actual affect on the text as far as I can tell. Should we deprecate this input?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IMPORTANT: brought some CSS from fund-styles as we can't release fund-styles not and can't use the RC version
Screenshots
User name is visible (no heading)
User name is not visible (heading)
