Remove Queue.js #233
Open
Remove Queue.js #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a scenario in
@cap-js/hanathat a blob column is streamed out of the database and is being inserted into a different table. When doing this theQueue.jsimplementation creates a dead lock. As the lob read request cannot be send while actively processing the insert statement.This PR solves this limitation by removing the
Queue.jsfrom the connection. Instead using thepacketCountto identify what callback to use when a response is received from the the HANA system.There is still a pseudo queue in the current implementation as simply sending the request to the system without waiting for an acknowledgement. Results in sporadic connection terminations by the HANA system. With the reason
invalid packet lengthwhile sending the exact same packets.