Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Playwright 1.39 #178

Merged
4,036 commits merged into from
Jan 8, 2024
Merged

Update for Playwright 1.39 #178

4,036 commits merged into from
Jan 8, 2024

Conversation

tmbrbr
Copy link
Contributor

@tmbrbr tmbrbr commented Oct 12, 2023

Merging with Firefox commit fdbb859

Updates to Firefox compatible with Playwright version 1.39 (Fixes #177)

Johannes J. Schmidt and others added 30 commits June 5, 2023 14:15
…ent - r=credential-management-reviewers,sgalich,dimi a=test-only

and enable the test again

Differential Revision: https://phabricator.services.mozilla.com/D179798
…w int64_t. r=media-playback-reviewers,chunmin, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179959
…em-reviewers,ahochheiden, a=dmeehan

Building with rustc 1.70 adds a dependency to the ntdll library through
libstd using NtCreateFile/NtWriteFile (it previously picked the symbols
at runtime).

Differential Revision: https://phabricator.services.mozilla.com/D180011
…eemeli a=pascalc

It is unfortunately undefined behavior and leads to problems with LLVM
16.

Differential Revision: https://phabricator.services.mozilla.com/D180061
…tions. r=glandium, a=dmeehan

Even tho rust-lang/rust#112337 is IMO a rust
bug, it's easy to work around in our code and it doesn't really affect
expressiveness.

Differential Revision: https://phabricator.services.mozilla.com/D180065
…addon suggestions. r=daisuke,fluent-reviewers,flod, a=dmeehan, l10n=flod

This uses the new label but only when the addon suggestion is shown as a best
match. Otherwise the suggestion will be shown in the usual Firefox Suggest group
so it should use that label.

I chose `-brand-product-name`, which is always "Firefox" even on Nightly. I
don't think it makes sense to talk about "Nightly extensions".

Differential Revision: https://phabricator.services.mozilla.com/D179868
…isuke, a=dmeehan

This implements the new required matching behavior, which isn't based on min
keyword length anymore. This is how it works:

* Use the full keywords in remote settings to generate keywords that contain the
  first word plus each possible substring after the first word. For example if a
  full keyword is "video download", then generate these keywords: "video",
  "video ", "video d", "video do", etc. If a full keyword is only one word, then
  use it as is. The keywords never change even when the user clicks "Show less
  frequently". This is implemented in `onRemoteSettingsSync()`, and I modified
  `SuggestionsMap.add()` to make it easy to generate new keywords from the
  strings in `suggestion.keywords`.
* Keep track of the number of times the user clicked "Show less frequently" in
  `showLessFrequentlyCount`.
* When a suggestion is fetched from the suggestions map, filter it out if the
  search string isn't long enough given the `showLessFrequentlyCount`. This is
  done in `makeResult()`.

Other changes:

* I made some of the private properties in `AddonSuggestions` public so that the
  xpcshell test can easily use them. I think it's OK for them to be public.
* Added `show_less_frequently_cap` to the RS config object so that we can
  specify a cap in RS as well as Nimbus.
* mv'ed test_quicksuggest_addResults.js to test_suggestionsMap.js, since I
  modified this file. I should have done that back when I replaced `addResults()`
  with `SuggestionsMap`.
* Fixed a bug in `SuggestionsMap.add()` where the same suggestion could be added
  multiple times to the array stored in the map, if it had duplicate keywords.

Differential Revision: https://phabricator.services.mozilla.com/D179867
…eemeli, a=dmeehan

It is unfortunately undefined behavior and leads to problems with LLVM
16.

Differential Revision: https://phabricator.services.mozilla.com/D180061
…TION_115_0b2_RELEASE a=release CLOSED TREE DONTBUILD
…ry allocation flags r=jandem, a=dmeehan

This calls CancelOffThreadIonCompile before changing the nursery allocation
flags to avoid the race condition with off-thread compilation reading these
flags.

Nursery::discardJitCodeForZone is renamed to make it clear that it also sets
JIT flags.

Differential Revision: https://phabricator.services.mozilla.com/D179542
…necko-reviewers,valentin, a=dmeehan

This avoids potential issues where multiple OnDataAvailable callbacks or
similar could theoretically be called concurrently on different
StreamTransportService threads when targeting the STS - these cases will
now target a TaskQueue on the STS instead, structurally ensuring serial
execution.

Differential Revision: https://phabricator.services.mozilla.com/D179984
cy -> 2d6b7baafd10924112c0d5817b1c7fff4c403e03
de -> ec98fb74db0a484dd0a4b77cfe133805ae08888a
es-AR -> 0fc410704d3d48eae1d6ace08c3eaa32f20497a9
fr -> 913339aa9121f1dbcb6f78c8e6e5676f68a195ff
he -> e8f376a3164397890841084dec220f3e267bca35
it -> 8be5b6bff2b29e0447a486e9d2ceef962142e8d7
ka -> 7b6a492d07042210acd107d247fad702c6ceec86
ko -> c6722f9c30add583ffd691227a8d4d99f2483849
oc -> 01610a448076c31113dbfd427a00f9c79aa32f1d
ru -> a6c8cb735bc5bf3df71dc2cf9514cce5f9304b25
sk -> 9b1ba3c0d78b76024aae4e7aa48cfadacde32ae1
tr -> 8411f3a86b8b608a885ee02d4e65c021081ae358
zh-CN -> 891e4ba6e0986c3a00ca439f422288e57f5ebe34
…-reviewers,sergesanspaille, a=dmeehan

There was a syntax error introduced in bug 1796380 that removed the flag
entirely. In practice, it didn't make a difference for us because clang
now defaults to PIE, but it can make a difference in environments where
the compiler is not using such a default.

However, on both Darwin and WASI, clang complains the flag is unused, so
we have to do something about it.

Differential Revision: https://phabricator.services.mozilla.com/D180279
…scriptor +tests r=rpl,devtools-reviewers,jdescottes, a=dmeehan

The WebExtensionDescriptorActor loaded extension modules with the
dedicated devtools loader, which returns a different instance than
the real module in the browser. Besides the code not being designed to
be loaded twice in the same browser instance, this has the following
devtools-protocol-observable consequences:

- Uninitialized AddonManager -> Unable to detect addon updates/uninstalls.
- Detached ExtensionParent -> Unable to observe the actual extension,
  including not seeing extension state such as warnings.

Differential Revision: https://phabricator.services.mozilla.com/D180292
… r=rpl,devtools-reviewers,jdescottes, a=dmeehan

Extension modules are singletons and must never be loaded through the
dedicated DevTools loader. This happens when --start-debugger-server is
used.

These files in question are primarily designed to support the Firefox
devtools, so I haven't created separate unit tests for these cases.
The kind of problem associated with this import pattern has been covered
by other patches in this bug.

Differential Revision: https://phabricator.services.mozilla.com/D180293
The goal of this patch is to avoid the bad store forwarding on
some Samsung phones

Differential Revision: https://phabricator.services.mozilla.com/D180268
…plicationCache should be defined r=emilio, a=test-only

Differential Revision: https://phabricator.services.mozilla.com/D180176
ffxbld and others added 21 commits June 26, 2023 10:53
… r=edgar, a=dmeehan

Due to previous fix, I need to update
`browser_fullscreen_exit_on_external_protocol.js` since internal fullscreen
event isn't dispatched before request is canceled.

Also, I add one more test for cancelling fullscreen during transition.

Differential Revision: https://phabricator.services.mozilla.com/D181955
…X_RELEASE_115_BASE a=release DONTBUILD CLOSED TREE
…2a28eea1a6 4d4fa6c989784cadba74fc27f5c2189d912974a9| CLOSED TREE DONTBUILD a=release
…X_RELEASE_114_END a=release DONTBUILD CLOSED TREE
…X_115_0_BUILD1 a=release CLOSED TREE DONTBUILD
Was introduced in bug 1831148, regresses the behaviour fixed by
bug 1419225.

Differential Revision: https://phabricator.services.mozilla.com/D182346
@tmbrbr tmbrbr self-assigned this Oct 12, 2023
@cla-assistant
Copy link

cla-assistant bot commented Oct 12, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 21 committers have signed the CLA.

✅ tmbrbr
❌ ffxbld
❌ Archaeopteryx
❌ Drekabi
❌ gregstoll
❌ aosmond
❌ emilio
❌ mkaply
❌ jandem
❌ hneiva
❌ KershawChang
❌ jcristau
❌ 92kns
❌ MReschenberg
❌ calixteman
❌ artines1
❌ makotokato
❌ dsmithpadilla
❌ mozkeeler
❌ dshin-moz
❌ jfx2006


ffxbld seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tmbrbr tmbrbr added upstream Issue related to upstream Firefox playwright Issues with playwright integration labels Oct 12, 2023
@tmbrbr tmbrbr marked this pull request as draft October 12, 2023 09:46
@tmbrbr tmbrbr changed the title WIP: Update for Playwright 1.39 Update for Playwright 1.39 Oct 12, 2023
@tmbrbr tmbrbr marked this pull request as ready for review October 12, 2023 12:38
@tmbrbr tmbrbr closed this pull request by merging all changes into SAP:main in c226e8e Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playwright Issues with playwright integration upstream Issue related to upstream Firefox
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Playwright 1.39