-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Playwright 1.39 #178
Conversation
…ent - r=credential-management-reviewers,sgalich,dimi a=test-only and enable the test again Differential Revision: https://phabricator.services.mozilla.com/D179798
…w int64_t. r=media-playback-reviewers,chunmin, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D179959
…w-reviewers,Standard8,m_kato, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D179890
…em-reviewers,ahochheiden, a=dmeehan Building with rustc 1.70 adds a dependency to the ntdll library through libstd using NtCreateFile/NtWriteFile (it previously picked the symbols at runtime). Differential Revision: https://phabricator.services.mozilla.com/D180011
…eemeli a=pascalc It is unfortunately undefined behavior and leads to problems with LLVM 16. Differential Revision: https://phabricator.services.mozilla.com/D180061
…tions. r=glandium, a=dmeehan Even tho rust-lang/rust#112337 is IMO a rust bug, it's easy to work around in our code and it doesn't really affect expressiveness. Differential Revision: https://phabricator.services.mozilla.com/D180065
…addon suggestions. r=daisuke,fluent-reviewers,flod, a=dmeehan, l10n=flod This uses the new label but only when the addon suggestion is shown as a best match. Otherwise the suggestion will be shown in the usual Firefox Suggest group so it should use that label. I chose `-brand-product-name`, which is always "Firefox" even on Nightly. I don't think it makes sense to talk about "Nightly extensions". Differential Revision: https://phabricator.services.mozilla.com/D179868
…isuke, a=dmeehan This implements the new required matching behavior, which isn't based on min keyword length anymore. This is how it works: * Use the full keywords in remote settings to generate keywords that contain the first word plus each possible substring after the first word. For example if a full keyword is "video download", then generate these keywords: "video", "video ", "video d", "video do", etc. If a full keyword is only one word, then use it as is. The keywords never change even when the user clicks "Show less frequently". This is implemented in `onRemoteSettingsSync()`, and I modified `SuggestionsMap.add()` to make it easy to generate new keywords from the strings in `suggestion.keywords`. * Keep track of the number of times the user clicked "Show less frequently" in `showLessFrequentlyCount`. * When a suggestion is fetched from the suggestions map, filter it out if the search string isn't long enough given the `showLessFrequentlyCount`. This is done in `makeResult()`. Other changes: * I made some of the private properties in `AddonSuggestions` public so that the xpcshell test can easily use them. I think it's OK for them to be public. * Added `show_less_frequently_cap` to the RS config object so that we can specify a cap in RS as well as Nimbus. * mv'ed test_quicksuggest_addResults.js to test_suggestionsMap.js, since I modified this file. I should have done that back when I replaced `addResults()` with `SuggestionsMap`. * Fixed a bug in `SuggestionsMap.add()` where the same suggestion could be added multiple times to the array stored in the map, if it had duplicate keywords. Differential Revision: https://phabricator.services.mozilla.com/D179867
…y cleared. r=dom-worker-reviewers,asuth, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D180072
…n-reviewers,rpl, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D180103
…eemeli, a=dmeehan It is unfortunately undefined behavior and leads to problems with LLVM 16. Differential Revision: https://phabricator.services.mozilla.com/D180061
…TION_115_0b2_RELEASE a=release CLOSED TREE DONTBUILD
…r=media-playback-reviewers,chunmin, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D179961
…eam; r=dom-storage-reviewers,jari, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D178017
…ari, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D179559
…ry allocation flags r=jandem, a=dmeehan This calls CancelOffThreadIonCompile before changing the nursery allocation flags to avoid the race condition with off-thread compilation reading these flags. Nursery::discardJitCodeForZone is renamed to make it clear that it also sets JIT flags. Differential Revision: https://phabricator.services.mozilla.com/D179542
…necko-reviewers,valentin, a=dmeehan This avoids potential issues where multiple OnDataAvailable callbacks or similar could theoretically be called concurrently on different StreamTransportService threads when targeting the STS - these cases will now target a TaskQueue on the STS instead, structurally ensuring serial execution. Differential Revision: https://phabricator.services.mozilla.com/D179984
cy -> 2d6b7baafd10924112c0d5817b1c7fff4c403e03 de -> ec98fb74db0a484dd0a4b77cfe133805ae08888a es-AR -> 0fc410704d3d48eae1d6ace08c3eaa32f20497a9 fr -> 913339aa9121f1dbcb6f78c8e6e5676f68a195ff he -> e8f376a3164397890841084dec220f3e267bca35 it -> 8be5b6bff2b29e0447a486e9d2ceef962142e8d7 ka -> 7b6a492d07042210acd107d247fad702c6ceec86 ko -> c6722f9c30add583ffd691227a8d4d99f2483849 oc -> 01610a448076c31113dbfd427a00f9c79aa32f1d ru -> a6c8cb735bc5bf3df71dc2cf9514cce5f9304b25 sk -> 9b1ba3c0d78b76024aae4e7aa48cfadacde32ae1 tr -> 8411f3a86b8b608a885ee02d4e65c021081ae358 zh-CN -> 891e4ba6e0986c3a00ca439f422288e57f5ebe34
…s. r=dao, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D180021
…-reviewers, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D179727
…-reviewers,sergesanspaille, a=dmeehan There was a syntax error introduced in bug 1796380 that removed the flag entirely. In practice, it didn't make a difference for us because clang now defaults to PIE, but it can make a difference in environments where the compiler is not using such a default. However, on both Darwin and WASI, clang complains the flag is unused, so we have to do something about it. Differential Revision: https://phabricator.services.mozilla.com/D180279
…tem-reviewers,sergesanspaille, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D180174
…eviewers,dimi a=test-only DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D179826
…es - a=repo-update, r=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D180316
…scriptor +tests r=rpl,devtools-reviewers,jdescottes, a=dmeehan The WebExtensionDescriptorActor loaded extension modules with the dedicated devtools loader, which returns a different instance than the real module in the browser. Besides the code not being designed to be loaded twice in the same browser instance, this has the following devtools-protocol-observable consequences: - Uninitialized AddonManager -> Unable to detect addon updates/uninstalls. - Detached ExtensionParent -> Unable to observe the actual extension, including not seeing extension state such as warnings. Differential Revision: https://phabricator.services.mozilla.com/D180292
… r=rpl,devtools-reviewers,jdescottes, a=dmeehan Extension modules are singletons and must never be loaded through the dedicated DevTools loader. This happens when --start-debugger-server is used. These files in question are primarily designed to support the Firefox devtools, so I haven't created separate unit tests for these cases. The kind of problem associated with this import pattern has been covered by other patches in this bug. Differential Revision: https://phabricator.services.mozilla.com/D180293
…ng dialog r=gvn, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D180334
The goal of this patch is to avoid the bad store forwarding on some Samsung phones Differential Revision: https://phabricator.services.mozilla.com/D180268
…plicationCache should be defined r=emilio, a=test-only Differential Revision: https://phabricator.services.mozilla.com/D180176
…pdate, r=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D181991
…dmeehan Differential Revision: https://phabricator.services.mozilla.com/D180086
… r=edgar, a=dmeehan Due to previous fix, I need to update `browser_fullscreen_exit_on_external_protocol.js` since internal fullscreen event isn't dispatched before request is canceled. Also, I add one more test for cancelling fullscreen during transition. Differential Revision: https://phabricator.services.mozilla.com/D181955
…pdfjs-reviewers, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D182005
…-reviewers, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D179727
…X_RELEASE_115_BASE a=release DONTBUILD CLOSED TREE
…2a28eea1a6 4d4fa6c989784cadba74fc27f5c2189d912974a9| CLOSED TREE DONTBUILD a=release
…X_RELEASE_114_END a=release DONTBUILD CLOSED TREE
…X_115_0_BUILD1 a=release CLOSED TREE DONTBUILD
…gcp, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D181767
…tdown, r=necko-reviewers,valentin, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D181986
…glandium, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D182098
Was introduced in bug 1831148, regresses the behaviour fixed by bug 1419225. Differential Revision: https://phabricator.services.mozilla.com/D182346
…Bug 1830588 for causing regressions
…Bug 1830588 for causing regressions
…Bug 1836693 for causing regressions
…=mhowell, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D182267
…r=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D182444
ffxbld seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Merging with Firefox commit fdbb859
Updates to Firefox compatible with Playwright version 1.39 (Fixes #177)