Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Thread Safety Analysis Exceptions #197

Merged
merged 1 commit into from
Feb 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dom/xhr/XMLHttpRequestString.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class XMLHttpRequestStringBuffer final {
mData.Append(aString);
}

void UnsafeAppendTaintAt(size_t aIndex, const StringTaint& aTaint)
void UnsafeAppendTaintAt(size_t aIndex, const StringTaint& aTaint) MOZ_NO_THREAD_SAFETY_ANALYSIS
{
// Caller must hold the lock
mData.Taint().concat(aTaint, aIndex);
Expand Down
5 changes: 3 additions & 2 deletions parser/html/nsHtml5StreamParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1727,8 +1727,9 @@ nsresult nsHtml5StreamParser::CopySegmentsToParserNoTaint(

/* static */ nsresult
nsHtml5StreamParser::CopySegmentsToParser(
nsITaintawareInputStream *aInStream, void *aClosure, const char *aFromSegment,
uint32_t aToOffset, uint32_t aCount, const StringTaint& aTaint, uint32_t *aWriteCount) {
nsITaintawareInputStream *aInStream, void *aClosure, const char *aFromSegment,
uint32_t aToOffset, uint32_t aCount, const StringTaint& aTaint,
uint32_t *aWriteCount) MOZ_NO_THREAD_SAFETY_ANALYSIS {
nsHtml5StreamParser* parser = static_cast<nsHtml5StreamParser*>(aClosure);

parser->DoDataAvailable(AsBytes(Span(aFromSegment, aCount)), aTaint);
Expand Down
Loading