New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Rust installation to build script #231

Merged

tmbrbr merged 1 commit into SAP:main from tmbrbr:build-script-rust

Oct 16, 2024

Contributor

tmbrbr commented Oct 16, 2024

Adding rust installation to the build script.

Normally this is done by the ./mach bootstrap command, but this is not ideal for the build script for a couple of reasons:

Removing the --no-system-changes would also do this, but also install system packages which requires root privileges. We want to avoid needing a sudo command.
By default, mach will install the latest version of rust, which may be too new by the time we get around to building. By installing ourselves, we can control the rust version which matches the firefox version (https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html)

This patch maintains the rust version in the .PLAYWRIGHT_VERSION file and makes sure it gets installed.


          Adding Rust installation to build script

0283f12

tmbrbr requested a review from leeN

October 16, 2024 11:02

leeN approved these changes

View reviewed changes

Collaborator

leeN left a comment

Looks good to me!

tmbrbr merged commit 95befff into SAP:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet