feature(Improve actions testing) #240
Conversation
# Conflicts: # dist/index.js # dist/index.js.map
…ect-piper-action into improve-actions-testing
# Conflicts: # dist/index.js.map
src/piper.ts
Outdated
| exportPipelineEnvironment: boolean | ||
| } | ||
| async function preparePiperPath (actionCfg: ActionConfiguration): Promise<string> { | ||
| info('Preparing Piper binary path with configuration '.concat(JSON.stringify(actionCfg))) |
There was a problem hiding this comment.
I'd turn this into debug log since users usually don't need such information in the logs.
src/piper.ts
Outdated
| enterpriseApi = process.env.GITHUB_API_URL | ||
| if (isEnterpriseStep(actionCfg.stepName)) { | ||
| info('Preparing Piper binary for enterprise step') | ||
| // devel:ContinuousDelivery:piper-library:ff8df33b8ab17c19e9f4c48472828ed809d4496a |
There was a problem hiding this comment.
please remove or replace ContinuousDelivery:piper-library, since it's SAP's internals and shouldn't be in open source part
src/github.ts
Outdated
| let piper = 'piper' | ||
| if (isEnterpriseStep) { | ||
| piper = 'sap-piper' | ||
| export function parseDevVersion (version: string): { owner: string, repository: string, commitISH: string } { |
There was a problem hiding this comment.
Considering that parseDevVersion isn't directly related to GitHub, it might be more appropriate to relocate it to build.ts.
src/build.ts
Outdated
| info(`Listing cwd: ${cwd()}`) | ||
| listFilesAndFolders(cwd()) | ||
|
|
||
| info(`Listing $path: ${path}`) | ||
| listFilesAndFolders(path) |
src/config.ts
Outdated
| exportPipelineEnvironment: getValue('export-pipeline-environment') === 'true' | ||
| } | ||
| } | ||
|
|
||
| export async function getDefaultConfig (server: string, apiURL: string, version: string, token: string, owner: string, repository: string, customDefaultsPaths: string): Promise<number> { |
There was a problem hiding this comment.
seems like getDefaultConfig function return value is not used. We can make the return type Promise<void> and use simple return instead of return 0
| } | ||
| } | ||
|
|
||
| export async function downloadDefaultConfig (server: string, apiURL: string, version: string, token: string, owner: string, repository: string, customDefaultsPaths: string): Promise<UploadResponse> { | ||
| let defaultsPaths: string[] = [] | ||
|
|
||
| // version: devel:..... | ||
| if (version.startsWith('devel:')) { |
There was a problem hiding this comment.
I'd add comment to clarify this condition:
// Since defaults file is located in release assets, we will take it from latest release
src/config.ts
Outdated
| @@ -150,6 +252,7 @@ export async function checkIfStepActive (stepName: string, stageName: string, ou | |||
| return result.exitCode | |||
| } | |||
|
|
|||
| // ? | |||
src/enterprise.ts
Outdated
| if (version.startsWith('devel:')) { | ||
| debug(`version starts with "devel:" => ${version}`) | ||
| debug(`params: ${owner}, ${repository}, ${version}, ${filename}`) | ||
| listFilesAndFolders(process.cwd()) |
src/enterprise.ts
Outdated
| debug(`version starts with "devel:" => ${version}`) | ||
| debug(`params: ${owner}, ${repository}, ${version}, ${filename}`) | ||
| listFilesAndFolders(process.cwd()) | ||
| version = '' |
There was a problem hiding this comment.
I suppose it should be latest here as well?
There was a problem hiding this comment.
either way its gets turned to latest in the getTag function but I changed it
src/download.ts
Outdated
|
|
||
| return piperPath | ||
| } | ||
| async function getPiperDownloadURL (piper: string, version?: string): Promise<string> { |
There was a problem hiding this comment.
I thnik we can safely turn version? into version, since there is no sense in expecting undefined here. Same applies to getTag function, where version: string | undefined can be turned into version: string
|
Please change the title of the PR to not include SAP internals. |
bitmaskit
changed the title
Description
Jira: https://jira.tools.sap/browse/HSPIPER-425
Feature to enable the usage of develop branches of inner source of piper for testing