chore(): Bugfix and refactor #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitmaskit
force-pushed
the
bugfix-and-refactor
branch
from
ddf9b2c to
b2ffae1
Compare
Googlom
reviewed
Mar 5, 2025
| @@ -124,5 +124,5 @@ export function getDownloadUrlByTag (version: string, forAPICall: boolean = fals | |||
| version = version.toLowerCase() | |||
| return (version === '' || version === 'master' || version === 'latest') | |||
| ? `${GITHUB_COM_SERVER_URL}/SAP/jenkins-library/releases/latest` | |||
| : `${GITHUB_COM_SERVER_URL}/SAP/jenkins-library/releases/${forAPICall ? 'tags' : 'tag'}/${version}` | |||
| : `${forAPICall ? `${GITHUB_COM_API_URL}/repos` : GITHUB_COM_SERVER_URL}/SAP/jenkins-library/releases/${forAPICall ? 'tags' : 'tag'}/${version}` | |||
There was a problem hiding this comment.
this will cause errors because all API requests must be authorized and but most of the pipelines don't have github.com token configured.
There was a problem hiding this comment.
This is just a helper function, if someone needs a download Url for API call they need to call this function with forAPICall: true. We dont have such call for now. It's responsibility of the caller (in the future) to make sure token is provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getDownloadUrlByTagactions/cachewhen we start to use single binary)