fix: Prevent blank order history page when using new tab component #19543
Conversation
feature-libs/cart/base/components/add-to-cart/add-to-cart.component.ts
Outdated
Show resolved
Hide resolved
| this.tabs$ = combineLatest([this.components$, this.tabRefs.changes]).pipe( | ||
| this.tabs$ = combineLatest([ | ||
| this.components$, | ||
| this.tabRefs.changes.pipe(startWith(this.tabRefs)), |
There was a problem hiding this comment.
After navigating to different route and back the tabRefs are already initialised with values and this.tabRefs.changes does not emit any value. This change ensures that at least the initial value will be taken into account. This solves the problem
There was a problem hiding this comment.
Nice find! Are we able to add an e2e test for the empty order history case just to make sure we have coverage?
sdrozdsap
force-pushed
the
bugfix/CXSPA-8712
branch
from
06eac48
to
687acad
Compare
Merge Checks Failed |
| if (this.featureConfigService.isEnabled('a11yPickupOptionsTabs')) { | ||
| if ( | ||
| this.featureConfigService.isEnabled('a11yPickupOptionsTabs') && | ||
| this.pickupOptionCompRef instanceof ComponentRef |
There was a problem hiding this comment.
This change is not directly related to the issue, but still its better to have this fix as soon as possible, since there is an error in console for b2b
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
bugfix/CXSPA-8712
|
| Run status |
|
| Run duration | 04m 50s |
| Commit |
|
| Committer | sdrozdsap |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
| this.tabs$ = combineLatest([this.components$, this.tabRefs.changes]).pipe( | ||
| this.tabs$ = combineLatest([ | ||
| this.components$, | ||
| this.tabRefs.changes.pipe(startWith(this.tabRefs)), |
There was a problem hiding this comment.
Nice find! Are we able to add an e2e test for the empty order history case just to make sure we have coverage?
No description provided.