Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip import of failed and in progress subscription #47

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

ANUGRAHG
Copy link
Member

@ANUGRAHG ANUGRAHG commented Sep 17, 2024

Purpose

  • Failed and in-progress subscriptions will now be skipped during export.
  • User will see information about the subscriptions that were skipped.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
make test
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Project board and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up issues are created and linked.

@ANUGRAHG ANUGRAHG added the enhancement New feature or request label Sep 17, 2024
@ANUGRAHG ANUGRAHG self-assigned this Sep 17, 2024
@ANUGRAHG ANUGRAHG requested a review from lechnerc77 September 17, 2024 07:51
@lechnerc77 lechnerc77 enabled auto-merge (squash) September 17, 2024 10:09
@lechnerc77 lechnerc77 merged commit 3f887f7 into main Sep 17, 2024
6 checks passed
@lechnerc77 lechnerc77 deleted the test branch September 17, 2024 10:10
@lechnerc77 lechnerc77 added the ignore-for-release All things not to be mentioned in release notes label Sep 17, 2024
@lechnerc77 lechnerc77 added this to the v0.1.0-beta1 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ignore-for-release All things not to be mentioned in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants