[FIX] minify: In case of error, include full resource path in the error messsage #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
reviewed
Jan 10, 2025
lib/processors/minifier.js
Outdated
| @@ -274,6 +274,7 @@ export default async function({ | |||
| filename, | |||
| dbgFilename, | |||
| code, | |||
| resourcePath: resource.getPath(), | |||
There was a problem hiding this comment.
resourcePath is already available as local variable. Or is the path changed in between?
There was a problem hiding this comment.
Thanks, you're right! Corrected 👍
…or messsage As suggested by Vest in SAP/ui5-tooling#890 (comment) This should make it easier to identify the resource that is causing an error in the minify task.
RandomByte
force-pushed
the
minify-error-full-path
branch
from
c257851 to
8afc2bd
Compare
matz3
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Vest in SAP/ui5-tooling#890 (comment), this should make it easier to identify the resource causing an error in the minify task.