Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): migrate to nx 19 and angular 18 #141

Closed
wants to merge 1 commit into from

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Aug 10, 2024

Related Issue(s)

closes

Description

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

Copy link

netlify bot commented Aug 10, 2024

Deploy Preview for ui5-webcomponents-ngx ready!

Name Link
🔨 Latest commit 4dd4b0b
🔍 Latest deploy log https://app.netlify.com/sites/ui5-webcomponents-ngx/deploys/66b7583325aa5b0008dbdd1b
😎 Deploy Preview https://deploy-preview-141--ui5-webcomponents-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@droshev droshev added the dependencies Pull requests that update a dependency file label Aug 10, 2024
@droshev droshev closed this Aug 10, 2024
@droshev droshev deleted the fix/nx-ng-migration branch August 10, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant