docs(ui5-list): improve "item-click" event description #10659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Maybe we should extend the note that it applies to any interactive component inside list item, not only for the selection ones. |
kgogov
force-pushed
the
list-docs-improve
branch
from
ed5179e to
fe669e9
Compare
Useful suggestion, thank you! |
nnaydenow
reviewed
Jan 30, 2025
packages/main/src/List.ts
Outdated
| * is set to `Inactive`. | ||
| * | ||
| * **Note**: This event will not trigger if the `selectionMode` property is set to a non-default value and an **interactive** component |
There was a problem hiding this comment.
I would write it:
Note: This event will not trigger if the
selectionModeproperty is set to a non-default value (where selection components such as checkboxes or radio buttons are displayed per item) or if any other interactive component (such as a button or input) within the list item is directly clicked.
kgogov
force-pushed
the
list-docs-improve
branch
from
fe669e9 to
f85b54c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #10183