Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-table): action header cell is added #10698

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

aborjinik
Copy link
Contributor

@aborjinik aborjinik commented Jan 29, 2025

a dedicated 'ui5-table-header-cell-action-ai' component is a added
sort-indicator property is added

@aborjinik aborjinik requested a review from DonkeyCo January 29, 2025 08:19
@aborjinik aborjinik force-pushed the table-header-cell-action branch 2 times, most recently from 3a8ade2 to 85eac5c Compare February 3, 2025 09:22
@aborjinik aborjinik requested review from DonkeyCo and KvM2 February 3, 2025 10:37
packages/main/src/TableHeaderCell.ts Outdated Show resolved Hide resolved
packages/main/src/TableHeaderCellActionBase.ts Outdated Show resolved Hide resolved
packages/main/src/TableHeaderCellActionBase.ts Outdated Show resolved Hide resolved
packages/main/src/TableHeaderCellActionBase.ts Outdated Show resolved Hide resolved
packages/main/src/TableHeaderCellActionBase.ts Outdated Show resolved Hide resolved
packages/main/src/types/TableSortOrder.ts Outdated Show resolved Hide resolved
@aborjinik aborjinik force-pushed the table-header-cell-action branch from 85eac5c to a5cc2a4 Compare February 4, 2025 16:52
@aborjinik aborjinik requested a review from KvM2 February 5, 2025 10:23
Copy link
Member

@DonkeyCo DonkeyCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments. LGTM so far

packages/main/src/TableHeaderCellActionBase.ts Outdated Show resolved Hide resolved
packages/main/src/TableHeaderCellActionAI.ts Outdated Show resolved Hide resolved
packages/main/src/types/TableSortOrder.ts Show resolved Hide resolved
@aborjinik aborjinik force-pushed the table-header-cell-action branch from a5cc2a4 to ad4afa3 Compare February 5, 2025 15:29
@aborjinik aborjinik requested review from KvM2 and DonkeyCo February 5, 2025 15:40
Copy link
Collaborator

@KvM2 KvM2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small thing I probably overlooked

@aborjinik aborjinik force-pushed the table-header-cell-action branch from ad4afa3 to 8ada763 Compare February 5, 2025 16:30
@aborjinik aborjinik requested a review from KvM2 February 5, 2025 16:30
Copy link
Member

@DonkeyCo DonkeyCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for @KvM2 approval as well

@aborjinik aborjinik merged commit ff6d77d into main Feb 6, 2025
12 checks passed
@aborjinik aborjinik deleted the table-header-cell-action branch February 6, 2025 09:48
dobromiraboycheva added a commit that referenced this pull request Feb 11, 2025
…ui5-settings

* 'main' of https://github.com/SAP/ui5-webcomponents:
  refactor(ui5-multi-combobox): switch to .tsx (#10807)
  refactor(ListItem): delete unused code (#10796)
  chore(deps-dev): bump esbuild from 0.19.9 to 0.25.0 (#10816)
  chore(deps-dev): bump vitest from 3.0.2 to 3.0.5 (#10785)
  test: add command for single cy test run (#10813)
  docs: fix TimelineGrowingMode enum docs (#10815)
  fix(ui5-side-navigation): remove inappropriate exclamation mark usage (#10769)
  feat(ui5-link): introduce reactive area size property (#10762)
  fix(ui5-side-navigation): "Space" key triggers links (#10767)
  chore(ui5-timeline): importing a timeline group item in the samples (#10793)
  chore: add ElementInternals shim (#10782)
  chore: fix MultiInput test (#10791)
  Translation Delivery (#10772)
  chore(ui5-select): remove unused css vars (#10789)
  chore: warn when scoping suffix is set too late (#10781)
  fix(ui5-button): remove tap highlight on safari (#10786)
  feat(ui5-table): action header cell is added (#10698)
  docs: fix List sample
  chore(release): publish v2.8.0-rc.0 [ci skip]
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.8.0-rc.1 🎉

The release is available on v2.8.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants