chore: add ElementInternals shim #10782
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
approved these changes
Feb 7, 2025
ilhan007
added a commit
that referenced
this pull request
Feb 7, 2025
With the introduce of the ButtonBadge, some users of jsdom complained of test failures because of the code below, caused by missing ElementInternals API in the jsdom env. As it's likely to need this for the SSR topic, we now provide a shim for `attachInternals` method, returning a shim for the ElementInternals class.
```ts
if (needsOverflowVisible) {
this._internals.states.add("has-overlay-badge"); // fails in jsdom
} else {
this._internals.states.delete("has-overlay-badge"); // fails in jsdom
}
```
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduce of the ButtonBadge, some users of jsdom complained of test failures because of the code below, caused by missing ElementInternals API in the jsdom env. As it's likely to need this for the SSR topic, we now provide a shim for
attachInternalsmethod, returning a shim for the ElementInternals class.