Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-button): update sample #10836

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix(ui5-button): update sample #10836

merged 2 commits into from
Feb 12, 2025

Conversation

didip1000
Copy link
Contributor

Updated the sample for the ui5-button with custom styling to align with the accessibility guidelines.

2025-02-12_13-55-54

@didip1000 didip1000 self-assigned this Feb 12, 2025
hinzzx
hinzzx reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@hinzzx hinzzx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we update the sample to showcase our best practices, could you please also update the selector to an attribute, since we support custom scoping

- ui5-button { // styles }
+ [ui5-button] { //styles }

@didip1000 didip1000 marked this pull request as ready for review February 12, 2025 13:20
@didip1000 didip1000 merged commit c34b6ca into main Feb 12, 2025
12 checks passed
@didip1000 didip1000 deleted the custom-button-sample branch February 12, 2025 13:20
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.8.0-rc.1 🎉

The release is available on v2.8.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinzzx hinzzx hinzzx approved these changes

Assignees

@didip1000 didip1000

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@didip1000 @ui5-webcomponents-bot @hinzzx