fix(ui5-menu): prevent global line-height inheritance #10916
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously setting a
line-height
property on global level e.gbody { line-height: 0.5rem }
was being inherited by theui5-menu
and itsui5-menu-item
's which was not convenient.With this chnange we now prevent the global inheritance of the
line-height
with the following priority:ui5-menu-item
>ui5-menu
>global (globally no longer takes effect)
, which means if aline-height
is set to theui5-menu
, all of its children (ui5-menu-items) would receive the effect, but if a specificui5-menu-item
receives the property, it would take over.For example, here all children, except the first one (which has explicitly set
style="line-height: 0.5rem;"
) would haveline-height
of1rem
Before
After
Fixes: #10754