fix(ui5-button): announce accessible name #11396
Open
+58
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
accessible-name
attribute is providedfor the
ui5-button
. The reason behind this behaviour is that the screen reader doesn'tread the inner text nodes of the root
button
node when the same hasaria-label
attribute.Solution:
aria-label
attribute of the rootbutton
element. As a result the screen reader won't rely on the inner text contentfor the announcements.
design
description is also moved into thearia-label
attribute,in order to keep a proper announcement order.
Fixes: #11350