Skip to content

fix(ui5-side-navigation): disabled groups no longer interactive #11404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(ui5-side-navigation): disabled groups no longer interactive #11404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
783963d
fix(ui5-side-navigation): disabled groups no longer interactive
s-todorova Apr 24, 2025
5263b63
chore: restore test page
s-todorova Apr 24, 2025
780283c
chore: fix test assertion
s-todorova Apr 24, 2025
a4ee1de
chore: ensure child items are also disabled
s-todorova Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 42 additions & 4 deletions packages/fiori/cypress/specs/SideNavigationWithGroups.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ import SideNavigationGroup from "../../src/SideNavigationGroup.js";
import SideNavigationItem from "../../src/SideNavigationItem.js";

describe("Component Behavior", () => {
describe("Main functionality", async () => {
it("rendering", async () => {
describe("Main functionality", () => {
it("rendering", () => {
cy.mount(
<SideNavigation style="height: 90vh; " id="sn1" collapsed={false}>
<SideNavigationItem text="Item" />
<SideNavigationGroup id="group1" expanded text="Group">
<SideNavigationItem text="Home 1"
icon="home"
Expand All @@ -28,15 +29,23 @@ describe("Component Behavior", () => {
.should("not.exist");
});

it("collapse/expand", async () => {
it("collapse/expand", () => {
cy.mount(
<SideNavigation style="height: 90vh; " id="sn1">
<SideNavigationItem text="Item" />
<SideNavigationGroup id="group1" expanded text="Group">
<SideNavigationItem text="Home 1"
icon="home"
href="#home"
title="Home tooltip" />
</SideNavigationGroup>
<SideNavigationItem text="Item" />
<SideNavigationGroup id="group2" disabled text="Group">
<SideNavigationItem text="Home 2"
icon="home"
href="#home"
title="Home tooltip" />
</SideNavigationGroup>
</SideNavigation>);

cy.get("#group1").should("have.prop", "expanded", true);
Expand All @@ -45,13 +54,42 @@ describe("Component Behavior", () => {
.shadow()
.find(".ui5-sn-item")
.realClick();
cy.get("#group1").should("not.have.prop", "expanded");
cy.get("#group1").should("have.prop", "expanded", false);

cy.get("#group1")
.shadow()
.find(".ui5-sn-item")
.realClick();
cy.get("#group1").should("have.prop", "expanded", true);

cy.get("#group2")
.shadow()
.find(".ui5-sn-item")
.realClick();
cy.get("#group2").should("have.prop", "expanded", false);
});

it("disabled", () => {
cy.mount(
<SideNavigation style="height: 90vh; " id="sn1">
<SideNavigationItem text="Item" />
<SideNavigationGroup id="group1" expanded text="Group 1">
<SideNavigationItem text="Home 1" />
<SideNavigationItem disabled text="Home 1" />
</SideNavigationGroup>
</SideNavigation>);

cy.get("#group1").should("not.have.attr", "disabled");
cy.get("#group1").invoke("prop", "disabled", true);
cy.get("#group1").should("have.attr", "disabled");

cy.get("#group1").then(($group) => {
const group = $group[0] as SideNavigationGroup;
cy.wrap(group.items).each((item: SideNavigationItem) => {
cy.wrap(item).should("have.prop", "disabled", true);
});
});
});

});
});
26 changes: 25 additions & 1 deletion packages/fiori/src/SideNavigationGroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,28 @@ class SideNavigationGroup extends SideNavigationItemBase {
@i18n("@ui5/webcomponents-fiori")
static i18nBundle: I18nBundle;

_initialChildDisabledStates: Map<SideNavigationItemBase, boolean> = new Map();

onBeforeRendering() {
this.allItems.forEach(item => {
if (!this._initialChildDisabledStates.has(item)) {
this._initialChildDisabledStates.set(item, item.disabled);
}
});

this._updateChildItemsDisabledState();
}

_updateChildItemsDisabledState() {
this.allItems.forEach(item => {
if (this.disabled) {
item.disabled = true;
} else {
item.disabled = this._initialChildDisabledStates.get(item)!;
}
});
}

get overflowItems() : Array<HTMLElement> {
const separator1 = this.shadowRoot!.querySelector<HTMLElement>(".ui5-sn-item-separator:first-child")!;
const separator2 = this.shadowRoot!.querySelector<HTMLElement>(".ui5-sn-item-separator:last-child")!;
Expand Down Expand Up @@ -161,7 +183,9 @@ class SideNavigationGroup extends SideNavigationItemBase {
}

_toggle() {
this.expanded = !this.expanded;
if (!this.disabled) {
this.expanded = !this.expanded;
}
}

get isSideNavigationGroup() {
Expand Down
5 changes: 5 additions & 0 deletions packages/fiori/test/pages/SideNavigationWithGroups.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@

<div style="float: right">
<ui5-checkbox id="collapsed" text="Collapsed"></ui5-checkbox>
<ui5-checkbox id="disable" text="disable group 1"></ui5-checkbox>
<ui5-checkbox id="density" text="Compact density"></ui5-checkbox>
<br>
<ui5-label for="slider" show-colon>Change width</ui5-label>
Expand All @@ -124,6 +125,10 @@
document.body.classList.toggle("ui5-content-density-compact", e.target.checked);
});

document.getElementById("disable").addEventListener("change", e => {
document.getElementById("group1").toggleAttribute("disabled", e.target.checked);
});

slider.addEventListener("ui5-input", function (event) {
sn1.style.width = event.target.value + 'px';
});
Expand Down
Loading