Skip to content

feat(ui5-search-field): introduce advanced filtering #11428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(ui5-search-field): introduce advanced filtering #11428

wants to merge 6 commits into from

Conversation

StefanDimitrov04
Copy link
Contributor

@StefanDimitrov04 StefanDimitrov04 commented Apr 28, 2025 •
edited
Loading

JIRA: BGSOFUIRILA-4036

@nnaydenow
Copy link
Contributor

Button's border radius could be changed using _ui5_button_focused_border_radius var as it is used in other components.

@StefanDimitrov04 StefanDimitrov04 marked this pull request as ready for review May 13, 2025 05:25
elenastoyanovaa
elenastoyanovaa requested changes May 13, 2025
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a sample in the playground as well.

@elenastoyanovaa
Copy link
Contributor

Add JIRA ID in the PR.

elenastoyanovaa
elenastoyanovaa requested changes May 14, 2025
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-05-14 at 17 04 25 fiori 3 on focus, not looking good Screenshot 2025-05-14 at 17 05 49 fiori 3 on hover not looking good

See collapsed search in Search.html for reference for fiori 3

@elenastoyanovaa
Copy link
Contributor

Regular focus:
Screenshot 2025-05-15 at 11 32 06
Focused hover:
Screenshot 2025-05-15 at 11 32 18

Compared to collapsed search on focus:
Screenshot 2025-05-15 at 11 33 05
focused collapsed search on hover:
Screenshot 2025-05-15 at 11 33 09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenastoyanovaa elenastoyanovaa elenastoyanovaa requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanDimitrov04 @nnaydenow @elenastoyanovaa