docs(UXC Pattern): extend with shellbar search and user menu #11443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrinyonkov
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request extends the UXC Pattern sample documentation by integrating a shellbar search with multiple search scopes and replacing the profile popover with a user menu component. Key changes include:
- Replacing the ui5-input with a ui5-shellbar-search element that supports multiple search scopes.
- Replacing the ui5-popover with a ui5-user-menu component to provide enhanced user account actions.
- Updating the main.js file to import the necessary modules and add event handlers for the new search and user menu components.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/website/docs/_samples/patterns/UXCIntegration/Basic/sample.html | Updated markup for shellbar search and introduced a new user menu component with account details. |
| packages/website/docs/_samples/patterns/UXCIntegration/Basic/main.js | Removed ui5-input dependencies, added imports for new components, and implemented event handling for user menu and search functionality. |
Comments suppressed due to low confidence (1)
packages/website/docs/_samples/patterns/UXCIntegration/Basic/sample.html:58
- [nitpick] The label 'Setting' might be ambiguous. Consider renaming it to 'Settings' to follow common UI text conventions.
<ui5-user-menu-item icon="action-settings" text="Setting" data-id="setting"></ui5-user-menu-item>
packages/website/docs/_samples/patterns/UXCIntegration/Basic/sample.html
Outdated
Show resolved
Hide resolved
packages/website/docs/_samples/patterns/UXCIntegration/Basic/main.js
Outdated
Show resolved
Hide resolved
…ample.html Co-authored-by: Copilot <[email protected]>
…ain.js Co-authored-by: Copilot <[email protected]>
PetyaMarkovaBogdanova
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Reference: BGSOFUIPIRIN-6810