Skip to content

chore(ui5-side-navigation): update overflow item accessible text #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

s-todorova
Copy link
Contributor

@s-todorova s-todorova commented May 8, 2025

JIRA: BGSOFUIRODOPI-3230

- add 'aria-description'
- update role form 'menuitem' to 'menuitemradio'

JIRA: BGSOFUIRODOPI-3230
@s-todorova s-todorova requested review from a team and Stoev May 8, 2025 08:11
@Stoev
Copy link

Stoev commented May 8, 2025

Tentative suggestion to make the optional text more descriptive:

  • add aria-description attribute
  • update role of overflow items form menuitem to menuitemradio

And one suggestion for the header:

update overflow items accessibility attributes

Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Otherwise looks good to me.

@s-todorova s-todorova changed the title chore(ui5-side-navigation): update overflow item accessibility chore(ui5-side-navigation): update overflow item accessible text May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants