-
Notifications
You must be signed in to change notification settings - Fork 277
chore(ui5-wizard): migrate wdio tests to cypress #11752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
use real events.
-
select by [custom-tag] instead of id where it's possible
-
cleanup template where it's possible
.as("disabledStep"); | ||
|
||
cy.get("@disabledStep") | ||
.click({ force: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realClick
); | ||
|
||
cy.get("[ui5-button]") | ||
.then($button => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need that click?
cy.mount( | ||
<Wizard id="asd"> | ||
<WizardStep icon="sap-icon://product" selected titleText="Product type"> | ||
<MessageStrip> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove message strip since it's nto part of the test
|
||
it("move to next step by click", () => { | ||
cy.mount( | ||
<Wizard id="asd"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the id?
No description provided.