chore(ui5-popover): migrate wdio tests to cypress #11757
Conversation
| cy.mount( | ||
| <> | ||
| <Button id="popoverOpen">Open</Button> | ||
| <Popover id="popover" opener="popoverOpen" open={true}> |
There was a problem hiding this comment.
this test doesn't match the description
| cy.mount( | ||
| <> | ||
| <Button id="popoverOpen">Open</Button> | ||
| <Popover id="popover1" opener="popoverOpen" open={true}> |
There was a problem hiding this comment.
split in 2 test if applicable
| </> | ||
| ); | ||
|
|
||
| // act |
There was a problem hiding this comment.
you already tested it with providing inital text. invoke is redudnatn
| cy.get("#btn").realClick(); | ||
|
|
||
| // Assert: Initially, the popover has an arrow | ||
| cy.get("#pop") |
There was a problem hiding this comment.
split this into 2 tests - one for checking the arrow and one when it's hidden
| cy.get("[ui5-popover]") | ||
| .shadow() | ||
| .find(".ui5-popup-root") | ||
| .should("have.attr", "aria-labelledby"); |
There was a problem hiding this comment.
split this into 2 tests: one for default text and one for custom
| <Button id="btnPopModal">Open Modal Popover</Button> | ||
| <Popover id="modalPopover" opener="btnPopModal" modal open={false}> | ||
| <Button id="modalPopoverClose" onClick={() => { | ||
| const popover = document.getElementById("modalPopover"); |
There was a problem hiding this comment.
this event listener is redudant. it's the same as to call invoke(prop, open, false) to the popover.
| ); | ||
|
|
||
| // Act: Open the modal popover | ||
| cy.get("#btnPopModal").click(); |
There was a problem hiding this comment.
realClick instead of click
| cy.get("#modalPopoverNoLayer").should("have.attr", "open", "open"); | ||
|
|
||
| // Act: Close the popover using Escape key | ||
| cy.get("body").realPress("Escape"); |
There was a problem hiding this comment.
realPress doesn't need to be called on exact element
| cy.get("body").realPress("Escape"); | ||
|
|
||
| // Assert: Popover is closed | ||
| cy.get("#modalPopoverNoLayer").should("not.be.visible"); |
There was a problem hiding this comment.
probably check that the block layer is not visible when the popover is opened?
| cy.get("body").then(body => { | ||
| let container = document.createElement("div"); | ||
| container.id = "container"; | ||
| body.get(0).appendChild(container); |
There was a problem hiding this comment.
append element to [data-cy-root] element otherwise the element will remain for next tests
|
some comments apply for the whole file so please check when addressing them. |
JIRA: BGSOFUIRODOPI-3462