Accommodate breaking changes for geometry refactoring #393
Conversation
|
thank you @knoepfel for the fast update! we will start testing/validating the set of geometry PRs |
|
@fjnicolas, no problem. I actually need to make a few more changes, but I'll let you know once this PR is ready for testing. |
|
Okay, @fjnicolas, this PR should now be ready for testing. |
|
Is there any updates to this? The larsoft PR changes this PR proposed to fix have both since been closed without merging. If it's still awaiting PRs, can you convert it to a draft PR? Thanks! |
|
These changes are necessary once LArSoft merges the The LArSoft PRs were closed because a dedicated |
|
Ok thanks for letting me know! I'll convert to a draft so it's known that we are not ready to merge this until larsoft v10 is out. |
| geo::TPCID tpcID = hits[0]->WireID().asTPCID(); | ||
| auto const [axis, sign] = GeometryService->TPC(tpcID).DriftAxisWithSign(); | ||
| if(axis != geo::Coordinate::X) return 0; | ||
| return to_int(sign); |
There was a problem hiding this comment.
This sign needs checking. It may be okay, but possibly not -- it depends on how this drift direction is used.
See:
and compare the sign for some hits in v10 vs v9
There was a problem hiding this comment.
If this direction is used in ConvertTicksToX for example, there might be a problem.
| return driftDirection; | ||
| auto const [axis, sign] = fGeometryService->TPC(tpcID).DriftAxisWithSign(); | ||
| if(axis != geo::Coordinate::X) return 0; | ||
| return to_int(sign); |
There was a problem hiding this comment.
Accommodate changes from:
N.B.: This PR should not be merged until the above PRs have been merged into a LArSoft release.