Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for running hitdumper without crt strip hits present #533

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Bug fix for running hitdumper without crt strip hits present #533

wants to merge 1 commit into from

Conversation

pgreen135
Copy link
Member

Bug fix for running hit-dumper module with CRT strip hits present: _n_crt_strip_hits is not initialised, then set to _max_crt_strip_hits in if statement at L589 resulting in seg-fault in subsequent loop

@pgreen135 pgreen135 changed the title Bug fix for running without crt strip hits present Bug fix for running hitdumper without crt strip hits present Oct 14, 2024
henrylay97
henrylay97 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@henrylay97 henrylay97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! Thanks @pgreen135

@bear-is-asleep bear-is-asleep added the crt Cosmic Ray Tagger label Oct 15, 2024
@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_91_02 SBNSoftware/sbncode@56dc342f SBNSoftware/sbnobj@a4b93770 e303cbe2 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrylay97 henrylay97 henrylay97 approved these changes

Assignees
No one assigned
Labels
crt Cosmic Ray Tagger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgreen135 @bear-is-asleep @FNALbuild @henrylay97