Add edit alias functionality for OfficeAccessCard (#1900) #1909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2025 22:28
- Implemented a new endpoint to edit card aliases, including validation for input. - Updated the OfficeAccessCard utility to support alias editing. - Enhanced the CardReader component to allow users to edit card aliases directly in the UI. - Added corresponding tests to ensure proper functionality and error handling for the new feature. - Introduced a new audit log action for alias edits.
adarshm11
reviewed
Sep 21, 2025
src/Pages/CardReader/CardReader.js
Outdated
Comment on lines
112
to
116
| setCards(prevCards => | ||
| prevCards.map(card => | ||
| card._id === cardId | ||
| ? { ...card, alias: editedAlias.trim() } | ||
| : card |
There was a problem hiding this comment.
i think what we should do here is when the alias is successfully edited, we query mongodb for all cards again, so that way this alias isn't only client side
src/Pages/Overview/SVG.js
Outdated
Comment on lines
54
to
62
| export function pencilSymbol(color = '#6b7280') { | ||
| return ( | ||
| <svg width='20' height='20' viewBox='0 0 24 24' fill='none' stroke={color} strokeWidth='2' strokeLinecap='round' strokeLinejoin='round'> | ||
| <path d='M11 4H4a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h14a2 2 0 0 0 2-2v-7'/> | ||
| <path d='m18.5 2.5a2.121 2.121 0 0 1 3 3L12 15l-4 1 1-4 9.5-9.5z'/> | ||
| </svg> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
this doesn't have to be put in this file, the trashCanSymbol function is only imported from here because it was already implemented here when card reader page was made. you can move this to CardReader.js
test/api/OfficeAccessCard.js
Outdated
Comment on lines
279
to
284
| it('Should return 400 when both _id and alias are missing', async () => { | ||
| setTokenStatus(true); | ||
| const result = await test.sendPostRequestWithToken(token, | ||
| EDIT_API_PATH, {}); | ||
| expect(result).to.have.status(BAD_REQUEST); | ||
| }); |
| expect(updatedCard.alias).to.equal(NEW_ALIAS); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
very impressive how thorough these tests are :)
evanugarte
reviewed
Oct 4, 2025
Comment on lines
+220
to
+223
| const decoded = decodeToken(req); | ||
| if (!decoded) { | ||
| return res.sendStatus(UNAUTHORIZED); | ||
| } |
There was a problem hiding this comment.
i think we realized this doesnt work anymore, need to merge #1877 first
ill work on it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Created a post /edit, and a helper function for edit alias.
-Created edit mode in pencil/edit button, that edits the alias when clicked.
-Created test files for post /edit with dummy document.