Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic checking periodic model faces #446

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

joshia5
Copy link

@joshia5 joshia5 commented Aug 9, 2024

Fix bug in logic checking periodic model faces when computing parametric coordinates

This PR is relating to issue #444

The PR is correcting the logic that checks if case is periodic and then only execute the lines

core/ma/maSnap.cc

Lines 502 to 511 in 60c507f

Vector x;
bool ok;
ok = m->isParamPointInsideModel(g, &p[0], x);
if (ok)
return;
for (int d=0; d < dim; ++d) {
bool isPeriodic = m->getPeriodicRange(g,d,range);
p[d] = interpolateParametricCoordinate(t,a[d],b[d],range,isPeriodic, 1);
}
that address periodic cases

@cwsmith
Copy link
Contributor

cwsmith commented Aug 12, 2024

/runtests

Copy link

Test Result: success (details)

@bobpaw
Copy link
Collaborator

bobpaw commented Sep 6, 2024

@joshia5 @cwsmith, is this ready to be merged?

@cwsmith
Copy link
Contributor

cwsmith commented Sep 6, 2024

/runtests

@cwsmith
Copy link
Contributor

cwsmith commented Sep 6, 2024

@bobpaw I'm running tests again (which now includes CGNS tests). If those pass I have no objections to merging this.

Copy link

github-actions bot commented Sep 6, 2024

Build Log
Simmetrix Test Result: success
Simmetrix + CGNS Test Result: failure

@cwsmith
Copy link
Contributor

cwsmith commented Sep 6, 2024

@joshia5 Would you mind rebasing this on develop? The CGNS tests are failing as this branch is missing some fixes.

@cwsmith
Copy link
Contributor

cwsmith commented Sep 9, 2024

/runtests

Copy link

github-actions bot commented Sep 9, 2024

Build Log
Simmetrix Test Result: success
Simmetrix + CGNS Test Result: success

@cwsmith cwsmith merged commit 7cd7647 into develop Sep 9, 2024
4 checks passed
@cwsmith cwsmith deleted the joshia5-periodic-gface branch September 9, 2024 18:07
bobpaw added a commit that referenced this pull request Sep 13, 2024
@cwsmith cwsmith added the v2.2.9 label Oct 23, 2024
@cwsmith cwsmith mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants