-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ta/mpas cell centers #35
base: cws/pumipicDps
Are you sure you want to change the base?
Conversation
@tomeravgil Please rebase this branch on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RPIFisherman: Yang, please look into this and make changes.
@tomeravgil: Tomer, Yang will help me finish this off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need changes and resolving conflicts. I will solve this, no worries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove personal attribute files, and put this in .gitignore
int nElms = p_mesh->getNumElements(); | ||
return nElms; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove empty lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this .mod
file.
zArray[i] = h_centersArray(i,2); | ||
} | ||
} | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't need the code, please remove it.
void polympo_setMeshVtxCoords(MPMesh_ptr p_mpmesh, int nCells, double* xArray, double* yArray, double* zArray); | ||
void polympo_getMeshVtxCoords(MPMesh_ptr p_mpmesh, int nCells, double* xArray, double* yArray, double* zArray); | ||
//void polympo_setMeshCellCenters(MPMesh_ptr p_mpmesh, int nCenters, double* xArray, double* yArray, double* zArray); | ||
//void polympo_getMeshCellCenters(MPMesh_ptr p_mpmesh, int nCenters, double* xArray, double* yArray, double* zArray); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented-out code.
! integer(c_int), value :: nVertices | ||
! type(c_ptr), value :: xArray, yArray, zArray | ||
!end subroutine | ||
!--------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented-out code.
@@ -105,6 +109,8 @@ class Mesh { | |||
IntElm2ElmView getElm2ElmConn() { return elm2ElmConn_; } | |||
template<MeshFieldIndex index> auto getMeshField(); | |||
void setMeshVtxBasedFieldSize(); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the empty line.
@@ -125,7 +125,8 @@ subroutine readMPASMesh(filename, maxEdges, vertexDegree, & | |||
nCells, nVertices, nEdgesOnCell, & | |||
onSphere, sphereRadius, & | |||
xVertex, yVertex, zVertex, & | |||
verticesOnCell, cellsOnCell) | |||
verticesOnCell, cellsOnCell)!,& | |||
!cellCenters) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented-out code.
! write(0, *) trim(nf90_strerror(status)) | ||
! stop | ||
!end if | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented-out code.
No description provided.