Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions #65

Merged
merged 15 commits into from
Aug 28, 2024
Merged

Update build instructions #65

merged 15 commits into from
Aug 28, 2024

Conversation

Angelyr
Copy link

@Angelyr Angelyr commented Aug 21, 2024

-Updates SCOREC instructions to work on RHEL9
-Combines build scripts into one and moves options to environment file

Co-authored-by: Cameron Smith <[email protected]>
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one small edit. Would you like me to test the instructions?

update: Checkers has an Ampere GPU. Sorry for the confusion with the edit 'suggestion'.

@Angelyr
Copy link
Author

Angelyr commented Aug 21, 2024

@cwsmith Yes that would be helpful. I've tested all four builds and it should work, but maybe there is something confusing in there.

@cwsmith
Copy link
Contributor

cwsmith commented Aug 21, 2024

OK. I'll give it a shot and keep you posted. Which SCOREC system(s) did you test on?

@Angelyr
Copy link
Author

Angelyr commented Aug 21, 2024

I've only tested on checkers

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build and tests worked as expected on checkers.

A few notes for the polympo section:

  • I think moving the clone command to the top of the section is a bit more intuitive.
  • IS_TESTING -> BUILD_TESTING ? CMake warned that IS_TESTING was ignored.
  • CMake warned that CMAKE_Fortran_COMPILER was ignored for the cws/pumipicDps branch. Is it used for other branches?

@Angelyr
Copy link
Author

Angelyr commented Aug 22, 2024

  • I moved the clone command to the top
  • I am not getting this warning. You can see the option here:
    option(IS_TESTING "Build for CTest" OFF)
  • I'm not getting this warning either. But I added the CMAKE_Fortran_COMPILER because I was having an issue on perlmutter where the it was using multiple fortran compilers.

@cwsmith
Copy link
Contributor

cwsmith commented Aug 22, 2024

Sounds good.

I was on the wrong polympo branch. Sorry about that.

I'll merge this if you are all set.

@Angelyr Angelyr merged commit dc94fca into cws/pumipicDps Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants