-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build instructions #65
Conversation
Co-authored-by: Cameron Smith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have one small edit. Would you like me to test the instructions?
update: Checkers has an Ampere GPU. Sorry for the confusion with the edit 'suggestion'.
@cwsmith Yes that would be helpful. I've tested all four builds and it should work, but maybe there is something confusing in there. |
OK. I'll give it a shot and keep you posted. Which SCOREC system(s) did you test on? |
I've only tested on checkers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build and tests worked as expected on checkers.
A few notes for the polympo section:
- I think moving the clone command to the top of the section is a bit more intuitive.
- IS_TESTING -> BUILD_TESTING ? CMake warned that IS_TESTING was ignored.
- CMake warned that CMAKE_Fortran_COMPILER was ignored for the cws/pumipicDps branch. Is it used for other branches?
|
Sounds good. I was on the wrong polympo branch. Sorry about that. I'll merge this if you are all set. |
-Updates SCOREC instructions to work on RHEL9
-Combines build scripts into one and moves options to environment file