Merge pull request #192 from SCasanova/devtest

Advance lifecycle anf CRAN comments
SCasanova · Oct 2, 2023 · 3dfa293 · 3dfa293
2 parents e5ffb2b + e64b016
commit 3dfa293
Show file tree

Hide file tree

Showing 67 changed files with 566 additions and 120 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: f1dataR
 Title: Access Formula 1 Data
-Version: 1.3.0.9000
+Version: 1.4.0
 Authors@R: c(
     person("Santiago", "Casanova", , "[email protected]", role = c("aut", "cre", "cph")),
     person("Philip", "Bulsink", , "[email protected]", role = "aut",

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,4 @@
-# f1dataR (development version)
+# f1dataR 1.4.0
 
 * Added a function `correct_track_ratio()` to ensure plotted tracks have proper x & y ratios (#89, #179)
   * Updated `plot_fastest()` to use `correct_track_ratio()`

diff --git a/R/load_driver_telemetry.R b/R/load_driver_telemetry.R
@@ -41,11 +41,11 @@ load_driver_telemetry <- function(season = get_current_season(), round = 1, sess
                                   fastest_only = lifecycle::deprecated()) {
   # Lifecycles
   if (lifecycle::is_present(race)) {
-    lifecycle::deprecate_warn("1.0.0", "load_driver_telemetry(race)", "load_driver_telemetry(round)")
+    lifecycle::deprecate_stop("1.4.0", "load_driver_telemetry(race)", "load_driver_telemetry(round)")
     round <- race
   }
   if (lifecycle::is_present(fastest_only)) {
-    lifecycle::deprecate_warn("1.1.0", "load_driver_telemetry(fastest_only)", "load_driver_telemetry(laps)")
+    lifecycle::deprecate_stop("1.4.0", "load_driver_telemetry(fastest_only)", "load_driver_telemetry(laps)")
     if (fastest_only) {
       laps <- "fastest"
     } else {
@@ -130,8 +130,8 @@ get_driver_telemetry <-
            log_level = "WARNING",
            fastest_only = lifecycle::deprecated(),
            race = lifecycle::deprecated()) {
-    lifecycle::deprecate_warn(
-      "1.0.0",
+    lifecycle::deprecate_stop(
+      "1.4.0",
       "get_driver_telemetry()",
       "load_driver_telemetry()"
     )

diff --git a/R/load_laps.R b/R/load_laps.R
@@ -13,7 +13,7 @@
 #' during lap, time (in clock form), lap number, time (in seconds), and season.
 load_laps <- function(season = get_current_season(), round = "last", race = lifecycle::deprecated()) {
   if (lifecycle::is_present(race)) {
-    lifecycle::deprecate_warn("1.0.0", "load_laps(race)", "load_laps(round)")
+    lifecycle::deprecate_stop("1.4.0", "load_laps(race)", "load_laps(round)")
     round <- race
   }
   if (season != "current" && (season < 1996 || season > get_current_season())) {

diff --git a/R/load_pitstops.R b/R/load_pitstops.R
@@ -14,7 +14,7 @@
 #' and stop duration
 load_pitstops <- function(season = get_current_season(), round = "last", race = lifecycle::deprecated()) {
   if (lifecycle::is_present(race)) {
-    lifecycle::deprecate_warn("1.0.0", "load_pitstops(race)", "load_pitstops(round)")
+    lifecycle::deprecate_stop("1.4.0", "load_pitstops(race)", "load_pitstops(round)")
     round <- race
   }
   if (season != "current" && (season < 2011 || season > get_current_season())) {

diff --git a/R/load_race_session.R b/R/load_race_session.R
@@ -36,7 +36,7 @@
 load_race_session <- function(obj_name = "session", season = get_current_season(), round = 1, session = "R",
                               log_level = "WARNING", race = lifecycle::deprecated()) {
   if (lifecycle::is_present(race)) {
-    lifecycle::deprecate_warn("1.0.0", "load_race_session(race)", "load_race_session(round)")
+    lifecycle::deprecate_stop("1.4.0", "load_race_session(race)", "load_race_session(round)")
     round <- race
   }
   if (season != "current" && (season < 2018 || season > get_current_season())) {

diff --git a/R/load_session_laps.R b/R/load_session_laps.R
@@ -28,7 +28,7 @@
 load_session_laps <- function(season = get_current_season(), round = 1, session = "R", log_level = "WARNING",
                               add_weather = FALSE, race = lifecycle::deprecated()) {
   if (lifecycle::is_present(race)) {
-    lifecycle::deprecate_warn("1.0.0", "load_session_laps(race)", "load_session_laps(round)")
+    lifecycle::deprecate_stop("1.4.0", "load_session_laps(race)", "load_session_laps(round)")
     round <- race
   }
 

diff --git a/R/plot_fastest.R b/R/plot_fastest.R
@@ -29,7 +29,11 @@ plot_fastest <- function(season = get_current_season(), round = 1, session = "R"
     cli::cli_abort("f1dataR::plot_fastest() requires ggplot2 package installation")
   }
   if (lifecycle::is_present(race)) {
-    lifecycle::deprecate_warn("1.0.0", "plot_fastest(race)", "plot_fastest(round)")
+    lifecycle::deprecate_stop(
+      "1.4.0",
+      "plot_fastest(race)",
+      "plot_fastest(round)"
+    )
     round <- race
   }
 

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,15 +1,11 @@
 ## Resubmission
 This is a resubmission. In this version we have:
 
-* Fixed an undiscovered bug in previous sumbission
+* Added freedom to the usesr's python enviroment
 
-* Eliminated any use of `getwd()` within the package (functions, tests and vignettes)
+* Advanced lifecycle on deprecations
 
-* Changed the caching process to give control to user (use `tempdir()` as default)
-
-* Added missing value parameters
-
-* Added API references to DESCRIPTION
+* Added a helper function for plot outputs
 
 ## R CMD check results
 
diff --git a/docs/404.html b/docs/404.html
diff --git a/docs/LICENSE-text.html b/docs/LICENSE-text.html
diff --git a/docs/LICENSE.html b/docs/LICENSE.html
diff --git a/docs/articles/ergast-data-analysis-driver_laptime_scatterplot-1.png b/docs/articles/ergast-data-analysis-driver_laptime_scatterplot-1.png
diff --git a/docs/articles/ergast-data-analysis-drivers_laptimes-1.png b/docs/articles/ergast-data-analysis-drivers_laptimes-1.png
diff --git a/docs/articles/ergast-data-analysis-grid_to_finish_one-1.png b/docs/articles/ergast-data-analysis-grid_to_finish_one-1.png
diff --git a/docs/articles/ergast-data-analysis-grid_to_finish_season-1.png b/docs/articles/ergast-data-analysis-grid_to_finish_season-1.png
diff --git a/docs/articles/ergast-data-analysis-quali_compare-1.png b/docs/articles/ergast-data-analysis-quali_compare-1.png
diff --git a/docs/articles/ergast-data-analysis-round_position-1.png b/docs/articles/ergast-data-analysis-round_position-1.png
diff --git a/docs/articles/ergast-data-analysis-rounds_points-1.png b/docs/articles/ergast-data-analysis-rounds_points-1.png
diff --git a/docs/articles/ergast-data-analysis.html b/docs/articles/ergast-data-analysis.html
diff --git a/docs/articles/index.html b/docs/articles/index.html
diff --git a/docs/articles/introduction-pitstop-1.png b/docs/articles/introduction-pitstop-1.png
diff --git a/docs/articles/introduction-session_laps-1.png b/docs/articles/introduction-session_laps-1.png
diff --git a/docs/articles/introduction-simple_plot-1.png b/docs/articles/introduction-simple_plot-1.png
diff --git a/docs/articles/introduction-telem_plotting-1.png b/docs/articles/introduction-telem_plotting-1.png
diff --git a/docs/articles/introduction-triple_plot-1.png b/docs/articles/introduction-triple_plot-1.png
diff --git a/docs/articles/introduction-use_builtin-1.png b/docs/articles/introduction-use_builtin-1.png
diff --git a/docs/articles/introduction-use_theme-1.png b/docs/articles/introduction-use_theme-1.png
diff --git a/docs/articles/introduction.html b/docs/articles/introduction.html
diff --git a/docs/articles/setup_fastf1.html b/docs/articles/setup_fastf1.html
diff --git a/docs/authors.html b/docs/authors.html