Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust API path #111

Closed
wants to merge 1 commit into from
Closed

Adjust API path #111

wants to merge 1 commit into from

Conversation

henrybrink
Copy link
Collaborator

@henrybrink henrybrink commented Apr 21, 2024

According to our API specification we are using the plural for resources ("/users/" instead of "/user"), this PR updates the path (and also is used to test modifications to the not working github action.

@benedictweis benedictweis self-requested a review April 22, 2024 05:47
@benedictweis
Copy link
Contributor

Is this supposed to be merged or is it just for testing purposes @henrybrink?. If it is supposed to be merged, I don't quite get why the route should be /users implying that getting a user by his id is /users/1. /user/1 "sounds" more sensible (see Github API Documentation).

@henrybrink
Copy link
Collaborator Author

I'll agree - as the backend action now is working we can close this PR

@henrybrink henrybrink closed this Apr 22, 2024
@benedictweis benedictweis deleted the dev/backend/fix-api-path branch June 19, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants