This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Integration with FitBit #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Brink <[email protected]>
Signed-off-by: Henry Brink <[email protected]>
Signed-off-by: Henry Brink <[email protected]>
Signed-off-by: Henry Brink <[email protected]>
Signed-off-by: Henry Brink <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
backend/src/integration/fitness/providers/fitbit.provider.spec.ts
Dismissed
Show dismissed
Hide dismissed
Signed-off-by: Henry Brink <[email protected]>
Signed-off-by: Henry Brink <[email protected]>
Signed-off-by: Henry Brink <[email protected]>
…e-format Signed-off-by: Henry Brink <[email protected]>
|
Awesome, thank you very much, I will add my review asap. |
benedictweis
suggested changes
Jun 3, 2024
|
I don't think that this implementation benefits from adding more tests. Tests are fine as they are at the moment in my opinion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes necessary to integrate Fitbit (and technically other providers) into our application.
With this PR it is possible, to link a Fitbit account to a local user account.
To do this, the user needs to perform the following actions:
/datasource/fitbit/authorizeNot everything in this PR is tested automatically, @benedictweis please look closely if we could add further tests, when they could make sense.