This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Provide Goals #234
Merged
Provide Goals #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybrink
added
enhancement
|
Will review tomorrow 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does/why we need it?:
This PR contains the implementation for the "/goal" endpoint. It will query the goals from the fitness provider.
The goals will be cached for one hour, if the cache is older than one hour, we will return the newest value.
Which Issues does this PR fix?:
Fixes #127
Also contains a very simplified form of caching, closing #140
Notes for reviewers: