Close open files on exec

Not really relevant for single-threaded selint, but pleases clang-tidy.
SELinuxProject · Jan 8, 2024 · 894af1c · 894af1c
1 parent ea4018f
commit 894af1c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/parse_fc.c b/src/parse_fc.c
@@ -231,7 +231,7 @@ bool check_for_fc_macro(const char *line, const struct string_list *custom_fc_ma
 
 struct policy_node *parse_fc_file(const char *filename, const struct string_list *custom_fc_macros)
 {
-	FILE *fd = fopen(filename, "r");
+	FILE *fd = fopen(filename, "re");
 
 	if (!fd) {
 		return NULL;

diff --git a/src/runner.c b/src/runner.c
@@ -41,7 +41,7 @@ struct policy_node *parse_one_file(const char *filename, enum node_flavor flavor
 	set_current_module_name(mod_name);
 	free(copy);
 
-	FILE *f = fopen(filename, "r");
+	FILE *f = fopen(filename, "re");
 	if (!f) {
 		printf("%sError%s: Failed to open %s: %s\n", color_error(), color_reset(), filename, strerror(errno));
 		return NULL;

diff --git a/src/startup.c b/src/startup.c
@@ -77,7 +77,7 @@ enum selint_error load_access_vectors_source(const char *av_path)
 
 	set_current_module_name(av_path);
 
-	FILE *f = fopen(av_path, "r");
+	FILE *f = fopen(av_path, "re");
 	if (!f) {
 		printf("%sError%s: Failed to open %s: %s\n", color_error(), color_reset(), av_path, strerror(errno));
 		return SELINT_IO_ERROR;
@@ -193,7 +193,7 @@ static char *strip_space(char *str)
 
 enum selint_error load_modules_source(const char *modules_conf_path)
 {
-	FILE *fd = fopen(modules_conf_path, "r");
+	FILE *fd = fopen(modules_conf_path, "re");
 
 	if (!fd) {
 		return SELINT_IO_ERROR;
@@ -242,7 +242,7 @@ enum selint_error load_modules_source(const char *modules_conf_path)
 
 enum selint_error load_obj_perm_sets_source(const char *obj_perm_sets_path)
 {
-	FILE *f = fopen(obj_perm_sets_path, "r");
+	FILE *f = fopen(obj_perm_sets_path, "re");
 	if (!f) {
 		return SELINT_IO_ERROR;
 	}
@@ -321,7 +321,7 @@ static enum selint_error load_global_conditions_file(const char *path)
 
 	set_current_module_name("__global__");
 
-	FILE *f = fopen(path, "r");
+	FILE *f = fopen(path, "re");
 	if (!f) {
 		printf("%sError%s: Failed to open file %s: %s\n", color_error(), color_reset(), path, strerror(errno));
 		return SELINT_IO_ERROR;