Update GitHub action for releases #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the matrix configuration definitions and logic in the 'Release Info' step for which one of those configurations to use is far apart in the main.yml file. If the matrix configuration ever changes it can be difficult to also remember to update the 'Release Info' step, which can lead to failed releases. To make this error less like, this adds a new 'is_release_job' matrix include that is set to false by default, but set to true for the one matrix configuration that should be used for building releases. Since these are near each other and all configured in the 'matrix' setting, it should hopefully be easier to remember to make updates if needed. Now matrix updates no longer require changes to the 'Release Info' step. This also modifies the 'Release Info' step to remove the deprecated set-output command: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
dburgener
approved these changes
Oct 5, 2023
|
Merged. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the matrix configuration definitions and logic in the 'Release Info' step for which one of those configurations to use is far apart in the main.yml file. If the matrix configuration ever changes it can be difficult to also remember to update the 'Release Info' step, which can lead to failed releases.
To make this error less like, this adds a new 'is_release_job' matrix include that is set to false by default, but set to true for the one matrix configuration that should be used for building releases. Since these are near each other and all configured in the 'matrix' setting, it should hopefully be easier to remember to make updates if needed. Now matrix updates no longer require changes to the 'Release Info' step.
This also modifies the 'Release Info' step to remove the deprecated set-output command:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/