Fix passing of argument with incompatible pointer type to fts_open() #273
Conversation
|
Seems reasonable except for the memory errors, thanks. I'm curious though, since this is a warning upgrading to an error, I'm not getting the warning on the current code base. I'm using gcc 13.2.1 and compiling with -Wall and -Wextra (per configure.ac). The github tool chain also adds -WError. So I don't understand why I'm not seeing the existing warning (probably as an error in CI). Any ideas? |
|
Currently, the warning is suppressed locally by the |
|
In hindsight, the function calls no longer need to be wrapped in these macros. |
With GCC 14, the incompatible-pointer-types warning will turn into an error by default. Due to this, the compilation of selint with newer versions of GCC would fail. This patch fixes 2 calls to fts_open() where this error occurs. As fts_open() expects an array of `char * const`, not `const char * const`, and the documentation does not guarantee that fts_open() will not modify the string, the argument needs to be copied (or initialized as an array instead of a pointer). Signed-off-by: Juraj Marcin <[email protected]>
JurajMarcin
force-pushed
the
fix-pointer-type
branch
from
d41bfb5
to
eb59ed7
Compare
|
Merged. Thanks! |
With GCC 14, the incompatible-pointer-types warning will turn into an error by default. Due to this, the compilation of selint with newer versions of GCC would fail.
This patch fixes 2 calls to
fts_open()where this error occurs. Asfts_open()expects an array ofchar * const, notconst char * const, and the documentation does not guarantee thatfts_open()will not modify the string, the argument needs to be copied (or initialized as an array instead of a pointer).