Call bison with -Wno-other #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bison in 3.8.2 added new warnings to catch m4 strings accidentally included in the generated code output. It had the unfortunate side effect of flagging grammars that include "m4_foo" style strings as identifiers in their grammar (which we do). Based on the thread, it looks like a fix was implemented on the Bison side, but as of three years later, no release has been made. Bison seems to possibly have maintainer inactivity: akimd/bison#103. Since a fix for the false positive is not forthcoming, disable the warning. Unfortunately, I don't think a more granular disablement is available, but IMO false positive warnings are worse than false negatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bison in 3.8.2 added new warnings to catch m4 strings accidentally included in the generated code output. It had the unfortunate side effect of flagging grammars that include "m4_foo" style strings as identifiers in their grammar (which we do). Based on the thread, it looks like a fix was implemented on the Bison side, but as of three years later, no release has been made. Bison seems to possibly have maintainer inactivity: akimd/bison#103.
Since a fix for the false positive is not forthcoming, disable the warning. Unfortunately, I don't think a more granular disablement is available, but IMO false positive warnings are worse than false negatives.