Skip to content

Commit

Permalink
vxlan: do not need BH again in vxlan_cleanup()
Browse files Browse the repository at this point in the history
vxlan_cleanup() is a timer callback, it is already
and only running in BH context.

Signed-off-by: Litao Jiao <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Litao Jiao authored and davem330 committed Mar 8, 2019
1 parent d394d33 commit f98ec78
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/vxlan.c
Original file line number Diff line number Diff line change
Expand Up @@ -2690,7 +2690,7 @@ static void vxlan_cleanup(struct timer_list *t)
for (h = 0; h < FDB_HASH_SIZE; ++h) {
struct hlist_node *p, *n;

spin_lock_bh(&vxlan->hash_lock);
spin_lock(&vxlan->hash_lock);
hlist_for_each_safe(p, n, &vxlan->fdb_head[h]) {
struct vxlan_fdb *f
= container_of(p, struct vxlan_fdb, hlist);
Expand All @@ -2712,7 +2712,7 @@ static void vxlan_cleanup(struct timer_list *t)
} else if (time_before(timeout, next_timer))
next_timer = timeout;
}
spin_unlock_bh(&vxlan->hash_lock);
spin_unlock(&vxlan->hash_lock);
}

mod_timer(&vxlan->age_timer, next_timer);
Expand Down

0 comments on commit f98ec78

Please sign in to comment.