Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to Community User/Contact Creation Script & NetworkMemberGroup Transform #73

Open
Julian88Tex opened this issue Apr 18, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Julian88Tex
Copy link
Contributor

A number of suggestions were made on PR #10 about ways to improve Community User/Contact Creation Script that should be considered:

  • verify uniqueness of usernames for each user creation to prevent attempting to create the same username twice
  • look into using an fstring for line creations
  • switch cci python class task usage from BaseSalesforceApiTask to just BaseTask
  • consider using a list for all profiles/permission sets in transform file
  • consider using the enumerate function for counting
  • look into less risky ways of creating and/or deleting the dataset load file

For more details on these suggestions, refer to PR #10.

@prescod
Copy link

prescod commented Apr 20, 2020

Also: if you're going to copy files, you could probably use this task:

https://cumulusci.readthedocs.io/en/latest/api/cumulusci.tasks.html#module-cumulusci.tasks.util

But I still think it would be better to not do "resetting" at all. Templates can be immutable and and outputs don't need to be reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants