Add scripts for creating a community user and adding profiles to community member groups #10

Julian88Tex · 2020-04-13T07:15:56Z

Critical Changes

Changes

created a script to generate a contact & user that is able to log into the community
created an ETL flow which creates a NetworkMemberGroup for the "Customer Community Customer Community - Health Authority", "Customer Community - Hospital Administrator", and "Customer Community - Medical Staff" profiles

Issues Closed

Julian88Tex · 2020-04-13T07:25:14Z

@jlantz this is definitely not ready for review since it's still messy and more a proof of concept right now, but could use your input on a couple of things.

Over this past weekend, I discovered that since a template is being used to create the community, I'm pretty sure I cannot load unpackaged Network Member Group metadata. Basically, this means I cannot give access to the community to the correct Permission Sets/Profiles.

As far as I can tell there are two ways to do this:

I can use the SOAP API. I'm not as familiar with this API, so I was wondering if CumulusCI is capable using it. I noticed a class in the repo referencing but not much cci documentation on it so wasn't sure if it is even possible.
I can use Bulk API with load_dataset task. I know cci can extract and load but can it easily transform the sql database after extraction? If not, I was thinking of writing a script to do this but seems pretty hacky so I was hoping there was a cleaner solution.

Thanks for any help!

…ttps://github.com/SFDO-Community/TractionThrive into feature/jjoseph/automate_community_contact_creation

…n load sql file

Add Python Script to Automate Id pulling from SQL file

Re-factor to combine two for loops

…task and flow to run transform script

… authority to network memeber group; add a new task to reset the nmg load file to it's original state; switch automatic user creation to medical staff

…ttps://github.com/SFDO-Community/TractionThrive into feature/jjoseph/automate_community_contact_creation

Julian88Tex · 2020-04-17T08:12:57Z

@sgovindankutty this is ready for review whenever you get a chance

outside of the code review here are some good steps to test:

pull this branch
run cci flow run qa_org on a scratch org
open org (cci org browser)
navigate to Staff object (which is Contacts renamed)
click on "Julian Joseph"
click button in upper right "Log in to Community as User"
verify community page loads properly with no error

jlantz

Looks good from a CumulusCI perspective. Would still be good to get a review from an Apex dev

davidmreed · 2020-04-18T00:05:49Z

scripts/community_user_setup.cls

+                        localesidkey = 'en_US', 
+                        Contactid = newContact.Id,
+                        timezonesidkey = 'Asia/Dubai', 
+                        username = newContact.email,


Org-scoped username uniqueness should in theory be on - any chance you've built two orgs with the same value here at the same time just to confirm?

davidmreed · 2020-04-18T00:06:59Z

tasks/nmg_transform.py

@@ -0,0 +1,47 @@
+from cumulusci.tasks.salesforce import BaseSalesforceApiTask
+
+class NgmTransForm(BaseSalesforceApiTask):


This doesn't need to be a BaseSalesforceApiTask; it doesn't talk to the API. Looks like BaseTask should be fine here.

davidmreed · 2020-04-18T00:07:56Z

tasks/nmg_transform.py

+            return line[index1:index2]
+
+        def createInsertLine(id, networkId, count):
+            insertLine = "INSERT INTO \"NetworkMemberGroup\" VALUES("


An fstring could clean this up nicely to make it clearer what the method intends to do.

davidmreed · 2020-04-18T00:10:01Z

tasks/nmg_transform.py

+            if 'Customer Community - Health Authority' in line:
+                ids.append(getId(line=line))
+            if '"Network" VALUES' in line:
+                networkId.append(getId(line=line))


You could do something here like

lines_to_look_for = ['Customer Community - Medical Staff', 'Customer Community - Hospital Administrator', 'Customer Community - Health Authority'] if any(search in line for search in lines_to_look_for): ids.append(getId(line=line))

and just handle the network id separately.

davidmreed · 2020-04-18T00:54:09Z

tasks/nmg_sql_reset.py

@@ -0,0 +1,13 @@
+from cumulusci.tasks.salesforce import BaseSalesforceApiTask
+
+class NgmSqlReset(BaseSalesforceApiTask):


This could also be a BaseTask.

davidmreed · 2020-04-18T00:55:38Z

tasks/nmg_transform.py

+            loadFile.write( createInsertLine(id = id, networkId = networkId[0], count = count ))
+            loadFile.write('\n')
+
+        loadFile.close()


Not a blocker, but I'm wondering if this could be achieved more expeditiously just by talking to the REST API rather than doing a bulk extract/transform/load. Can't say as I've tried to load this particular object before.

@davidmreed yeah that would have been ideal but unfortunately you cannot manipulate Network Member Group through Rest API. You can only use SOAP or bulk. If there is a SOAP way that is better I'm all ears!

That is... Nuts. I had no idea there were such objects. Thanks for the enlightenment. Bulk it is!

@davidmreed Yeah same here. I've learned so much about communities in the last week. It's a whole other world of metadata!

prescod · 2020-04-18T00:51:33Z

tasks/nmg_transform.py

+                networkId.append(getId(line=line))
+
+        loadFile.write('\n')
+        for id in ids:


There's a nice function called "enumerate" that allows you to count items at the same time. It would look like:

for count, id in enumerate(ids, 1): ...

prescod · 2020-04-18T00:52:03Z

tasks/nmg_transform.py

+            # profile you'd like to add a network member group for
+            if 'Customer Community - Medical Staff' in line:
+                ids.append(getId(line=line))
+            if 'Customer Community - Hospital Administrator' in line:


might use elif here?

prescod · 2020-04-18T00:53:15Z

tasks/nmg_transform.py

+            # Replace 'Customer Community - Medical Staff' with the permission set or 
+            # profile you'd like to add a network member group for
+            if 'Customer Community - Medical Staff' in line:
+                ids.append(getId(line=line))


Might not need to use a keyword argument syntax for a single-argument function.

prescod · 2020-04-18T00:57:26Z

cumulusci.yml

+                    mapping: datasets/mapping-nmg-load.yml
+                    sql_path: datasets/nmg-load.sql
+            4:
+                task: reset_nmg_sql


Something seems a bit weird about modifying a file and then resetting it. Can't you just make a brand new file and then delete or ignore it?

Why does the repository need to contain datasets/nmg-load.sql at all, if it is just a copy of the template? Instead of appending to it couldn't you read the template, write it, and then continue adding to it? I might miss something.

This way feels a bit risky because if the flow fails (which they often do) then the file could be in a weird state and you'd append to a file in the wrong state.

Julian88Tex · 2020-04-18T23:34:20Z

@prescod @davidmreed @jlantz Thanks for all the feedback! Since none are blockers I'm gonna recommend this for merge, but I've captured the suggestions in #73 so these scripts can be improved down the line.

Julian88Tex · 2020-04-18T23:35:24Z

@camgood-trac the release engineering team at Salesforce.org has approved this org-setup related PR with non-blocker suggestions that I've captured in issue #73. Feel free to review and/or merge whenever you're ready :-)

add script for creating a community user

490b64b

Julian88Tex requested a review from jlantz April 13, 2020 07:16

sirgeoffrey and others added 27 commits April 13, 2020 14:06

Merge f5b53ff into feature/jjoseph/automate_community_contact_creation

9494b98

Merge feb4baa into feature/jjoseph/automate_community_contact_creation

2f7f660

Merge 1a11d2d into feature/jjoseph/automate_community_contact_creation

34df84c

Merge 623a9b3 into feature/jjoseph/automate_community_contact_creation

035cd5a

Merge 29c4604 into feature/jjoseph/automate_community_contact_creation

2e4ad11

Merge b642762 into feature/jjoseph/automate_community_contact_creation

57b34c4

Merge 8ba8b01 into feature/jjoseph/automate_community_contact_creation

d94b80e

Merge f64435c into feature/jjoseph/automate_community_contact_creation

0722e41

Merge fb78ade into feature/jjoseph/automate_community_contact_creation

d9339c5

Merge 9009da9 into feature/jjoseph/automate_community_contact_creation

fbdae48

restore sample.sql

1e2105c

Merge branch 'feature/jjoseph/automate_community_contact_creation' of h…

5e13563

…ttps://github.com/SFDO-Community/TractionThrive into feature/jjoseph/automate_community_contact_creation

Merge e15d8f1 into feature/jjoseph/automate_community_contact_creation

3c3daf7

Merge 5b84cf9 into feature/jjoseph/automate_community_contact_creation

8b9bd2f

Merge 656896d into feature/jjoseph/automate_community_contact_creation

d590afc

add in profile to extract files

faa0fed

add back in network from a better org pull

741785c

Python script to take desired Ids from sql extact file and put them i…

36857a6

…n load sql file

Merge pull request #47 from sungysang/feature/ssong/add_python_script

bf1a4ca

Add Python Script to Automate Id pulling from SQL file

Re-factor to combine two for loops

146e3e2

Merge pull request #50 from sungysang/feature/ssong/refactor_script

f1f3ba3

Re-factor to combine two for loops

update ngm_transform task to work with cumulusci; create a cumulusci …

2f5056f

…task and flow to run transform script

Merge 3494b50 into feature/jjoseph/automate_community_contact_creation

2f836ca

remove einstein permission and instead add medical staff, adming, adn…

c27d2c9

… authority to network memeber group; add a new task to reset the nmg load file to it's original state; switch automatic user creation to medical staff

Merge e030a8e into feature/jjoseph/automate_community_contact_creation

c0ce498

remove extract contents

3db74d0

Merge branch 'feature/jjoseph/automate_community_contact_creation' of h…

330eac3

…ttps://github.com/SFDO-Community/TractionThrive into feature/jjoseph/automate_community_contact_creation

Julian Joseph added 2 commits April 16, 2020 21:32

add it reset for nmg-extract as well

6bafdc0

add comments and do a little formatting

61ec8a2

Julian88Tex self-assigned this Apr 17, 2020

Julian88Tex requested a review from sgovindankutty April 17, 2020 08:08

sirgeoffrey added 2 commits April 17, 2020 12:02

Merge 5045a32 into feature/jjoseph/automate_community_contact_creation

3a68a7b

Merge cebe0b8 into feature/jjoseph/automate_community_contact_creation

a6b7dd4

Julian88Tex requested a review from prescod April 17, 2020 23:44

Julian88Tex changed the title ~~add script for creating a community user and assigning member permission set~~ Add scripts for creating a community user and adding profiles to community member groups Apr 17, 2020

jlantz approved these changes Apr 18, 2020

View reviewed changes

davidmreed requested changes Apr 18, 2020

View reviewed changes

prescod reviewed Apr 18, 2020

View reviewed changes

sirgeoffrey added 3 commits April 17, 2020 23:12

Merge 6c2deab into feature/jjoseph/automate_community_contact_creation

7cc0c07

Merge e2ab922 into feature/jjoseph/automate_community_contact_creation

58a578d

Merge e740415 into feature/jjoseph/automate_community_contact_creation

9aff2af

Julian88Tex mentioned this pull request Apr 18, 2020

Improvement to Community User/Contact Creation Script & NetworkMemberGroup Transform #73

Open

sirgeoffrey added 4 commits April 20, 2020 16:58

Merge 3c15d44 into feature/jjoseph/automate_community_contact_creation

c065efc

Merge 0bbd62a into feature/jjoseph/automate_community_contact_creation

abdb769

Merge 9118c2d into feature/jjoseph/automate_community_contact_creation

0944f86

Merge 97fffa5 into feature/jjoseph/automate_community_contact_creation

f11641d

ghost merged commit aef1e24 into master Apr 22, 2020

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add scripts for creating a community user and adding profiles to community member groups #10

Add scripts for creating a community user and adding profiles to community member groups #10

Julian88Tex commented Apr 13, 2020 •

edited

Loading

Julian88Tex commented Apr 13, 2020

Julian88Tex commented Apr 17, 2020

jlantz left a comment

davidmreed Apr 18, 2020

davidmreed Apr 18, 2020

davidmreed Apr 18, 2020

davidmreed Apr 18, 2020 •

edited

Loading

davidmreed Apr 18, 2020

davidmreed Apr 18, 2020

Julian88Tex Apr 18, 2020

davidmreed Apr 18, 2020

Julian88Tex Apr 18, 2020

prescod Apr 18, 2020

prescod Apr 18, 2020

prescod Apr 18, 2020

prescod Apr 18, 2020

prescod Apr 18, 2020

Julian88Tex commented Apr 18, 2020

Julian88Tex commented Apr 18, 2020 •

edited

Loading

		@@ -0,0 +1,47 @@
		from cumulusci.tasks.salesforce import BaseSalesforceApiTask

		class NgmTransForm(BaseSalesforceApiTask):

		@@ -0,0 +1,13 @@
		from cumulusci.tasks.salesforce import BaseSalesforceApiTask

		class NgmSqlReset(BaseSalesforceApiTask):

Add scripts for creating a community user and adding profiles to community member groups #10

Add scripts for creating a community user and adding profiles to community member groups #10

Conversation

Julian88Tex commented Apr 13, 2020 • edited Loading

Critical Changes

Changes

Issues Closed

Julian88Tex commented Apr 13, 2020

Julian88Tex commented Apr 17, 2020

jlantz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidmreed Apr 18, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Julian88Tex commented Apr 18, 2020

Julian88Tex commented Apr 18, 2020 • edited Loading

Julian88Tex commented Apr 13, 2020 •

edited

Loading

davidmreed Apr 18, 2020 •

edited

Loading

Julian88Tex commented Apr 18, 2020 •

edited

Loading