Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/jul2024 sf codescanner cleanup #42

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Feature/jul2024 sf codescanner cleanup #42

merged 2 commits into from
Jul 12, 2024

Conversation

pickettd
Copy link
Contributor

Critical Changes

Changes

  • Added explicit eslint config file to use the LWC plugin
  • SF codescanner had a few best practice issues highlighted (mostly in the Apex code) - this PR implements those best practices

Issues Closed

pickettd added 2 commits July 10, 2024 14:36
@pickettd
Update dev dependencies for eslint run using lwc plugin. Update code …
42b7ab1 
…in lwc that uses Apex to fetch column names on load to have eslint ignore declarations
@pickettd
Add best practice suggestions from sf codescanner
0e28a2d
@pickettd pickettd requested review from kalena, bhanudas and roanbear July 11, 2024 01:16
kalena
kalena approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@kalena kalena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. SF Scanner reported an issue for stickySelectronMain.js file for a Severity 2 eslint problem for rule @lwc/lwc/no-api-reassignments on Line 2 Column 1. Confirmed with @pickettd that this was a false positive.

@kalena kalena merged commit 2907b57 into main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalena kalena kalena approved these changes

@bhanudas bhanudas Awaiting requested review from bhanudas

@roanbear roanbear Awaiting requested review from roanbear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pickettd @kalena