Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS loader icon based on Apex and records load completion #56

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Update JS loader icon based on Apex and records load completion #56

merged 1 commit into from
Dec 5, 2024

Conversation

pickettd
Copy link
Contributor

@pickettd pickettd commented Dec 5, 2024

Critical Changes

Changes

  • Add helper function to determine when we should show the loading icon based on LWC render, data from flow loaded, and metadata about fields

Issues Closed

@pickettd
Add helper function to determine when we should show the loading icon…
89efe3c 
… based on LWC render, data from flow loaded, and metadata about fields
roanbear
roanbear approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@roanbear roanbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David

@pickettd pickettd merged commit d3f49c8 into main Dec 5, 2024
2 checks passed
@pickettd pickettd deleted the feature/dec05-expand-JS-loader-logic-for-apex-metadata branch December 5, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roanbear roanbear roanbear approved these changes

@kalena kalena Awaiting requested review from kalena

@bhanudas bhanudas Awaiting requested review from bhanudas

@mattm6789 mattm6789 Awaiting requested review from mattm6789

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pickettd @roanbear