Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError when service sensitive attribute is None #3674

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix TypeError when service sensitive attribute is None #3674

merged 2 commits into from
Oct 24, 2023

Conversation

jain-naman-sf
Copy link
Contributor

Fixed the exception for the command cci service info connected_app while built_in is default

@jain-naman-sf jain-naman-sf requested a review from a team as a code owner October 12, 2023 05:44
@jain-naman-sf jain-naman-sf changed the title Bug Fixed Fixed cci service info connected_app exception Oct 12, 2023
@jstvz jstvz changed the title Fixed cci service info connected_app exception Fix TypeError when service sensitive attribute is None Oct 24, 2023
jstvz
jstvz approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a test case for this would be nice, but not a blocker.

@jstvz jstvz enabled auto-merge (squash) October 24, 2023 19:03
@jstvz jstvz merged commit 520b511 into main Oct 24, 2023
16 of 18 checks passed
@jstvz jstvz deleted the bug/cci-service-info-connected_app-exception branch October 24, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstvz jstvz jstvz approved these changes

@jkasturi-sf jkasturi-sf Awaiting requested review from jkasturi-sf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jain-naman-sf @jstvz