W42 dependency updates #3686
Merged
W42 dependency updates #3686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: We should split extras into their own requirements files since we're only doing this to make sure the dependency's version is the same in prod as under test.
1. Robot framework team removed the add_path function in robotframework/robotframework@9a87af, this commit adds a utility function with the same behavior. 2. Probably unrelated to 6.1, but keyword.source is a Path instance now, so we needed to convert it to a str for a comparison. 3. Latest flake8 includes a type comparison rule.
Updating to pyright<=1.1.306 made it so much smarter that it broke several files: - sarge.Command: uses setattr to dynamically add stderr_text - sqlalchemy: see [this issue]. - github3: Return type for GitHub.repository() is actually `Repository | None` Removing instead of using `pyright: ignore` because the last two are actually valid errors. [this issue]: microsoft/pyright#5062 (comment)
I have no idea what's happening here. At first glance it appears to be a regression, but I can't reproduce within Snowfakery's repo on 3.5.0 or 3.4.0.
davidmreed
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.