Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-17366392: Fix Omnistudio issues for the sf command format #3855

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

lakshmi2506
Copy link
Contributor

No description provided.

@lakshmi2506 lakshmi2506 requested a review from a team as a code owner December 6, 2024 15:53
jkasturi-sf
jkasturi-sf previously approved these changes Dec 6, 2024
Copy link
Contributor

@jkasturi-sf jkasturi-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VBT tool is not supporting SF cli. So reverting back to SFDX Cli

@lakshmi2506 lakshmi2506 requested review from vsbharath and a team December 6, 2024 16:23
Copy link
Contributor

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lakshmi2506 this PR changes from sf back to sfdx. Since CumulusCI already uses sf, going back might cause problems for people who depend on the newer commands. Could you please share the exact errors you saw when using sf?

The Vlocity team mentioned that using the useSfCli setting and the 1.17.10 release might fix these issues. Have we tried that yet?

Could we discuss:

  • The exact error messages you encountered when using sf?
  • The results of testing useSfCli with version 1.17.10?

We should have a plan for what happens when we run into commands that only work with sfdx. For example, could we make the build fail with a clear error message, rather than quietly switching back and forth between sf and sfdx?

@lakshmi2506 lakshmi2506 changed the title @W-17366392: Fix Omnistudio issues for the compatibility with sfdx @W-17366392: Fix Omnistudio issues for the compatibility with sfdx ##DO NOT MERGE## Dec 6, 2024
@jstvz jstvz changed the title @W-17366392: Fix Omnistudio issues for the compatibility with sfdx ##DO NOT MERGE## @W-17366392: Fix Omnistudio issues for the compatibility with sfdx Dec 6, 2024
@lakshmi2506 lakshmi2506 requested a review from jstvz December 11, 2024 03:32
@lakshmi2506 lakshmi2506 changed the title @W-17366392: Fix Omnistudio issues for the compatibility with sfdx @W-17366392: Fix Omnistudio issues for the sf command format Dec 11, 2024
vsbharath
vsbharath previously approved these changes Dec 11, 2024
@vsbharath vsbharath merged commit 865ad49 into main Dec 11, 2024
14 of 19 checks passed
@vsbharath vsbharath deleted the fix_omnistudio_issues branch December 11, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants