Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

Lookup Chromedriver version using installed Chrome #1

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Lookup Chromedriver version using installed Chrome #1

wants to merge 2 commits into from

Conversation

jstvz
Copy link

@jstvz jstvz commented Jun 1, 2022

  • Lookup Chromedriver version using installed Chrome
  • Validate chromedriver

jstvz added 2 commits June 1, 2022 11:06
@jstvz
Lookup Chromedriver version using installed Chrome
3d6c5d9 
This commit updates the chromedriver buildpack to retrieve the correct
chromedriver version based on the installed version of Google Chrome.
During major releases there is a brief window where mismatching versions
can be installed. This change uses the major.minor.patch based on the
[chromedriver docs].

This change requires that heroku-buildpack-google-chrome come first in
the order of buildpacks.

For similar approaches see:

- heroku#28
- heroku#36

[chromedriver docs]: https://chromedriver.chromium.org/downloads/version-selection
@jstvz
Validate chromedriver
369cc77 
This change will attempt to validate that chromedriver is working as
expected.
@jstvz jstvz changed the title patch chromedriver version Lookup Chromedriver version using installed Chrome Jun 1, 2022
@jstvz jstvz marked this pull request as draft June 1, 2022 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jstvz