Skip to content

Commit

Permalink
fix: DAH-2853 fix bug and add bolding (#2371)
Browse files Browse the repository at this point in the history
* DAH-2853 bump markdown to fix bug introduced and bold a few missed places

* DAH-2853 fix unneeded change

* DAH-2853 update snapshot
  • Loading branch information
tallulahkay authored Oct 22, 2024
1 parent 59b9db0 commit 64e941f
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 11 deletions.
4 changes: 2 additions & 2 deletions app/assets/json/translations/react/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -611,8 +611,8 @@
"howToApplyPage.howToApplySection.step5.p1": "When you are ready, submit your application in 3 steps:",
"howToApplyPage.howToApplySection.step5.p2": "The time and date you apply determines your place in line.",
"howToApplyPage.howToApplySection.step5.title": "Submit your application and get your place in line",
"howToApplyPage.whatHappensNext.p1": "We will email you your place in line within 2 business days. If anyone applied before you, we review their application(s) first.",
"howToApplyPage.whatHappensNext.p2": "If your application is approved, you will need to enter a purchase agreement within 7 days.",
"howToApplyPage.whatHappensNext.p1": "We will email you your place in line within <b>2 business days</b>. If anyone applied before you, we review their application(s) first.",
"howToApplyPage.whatHappensNext.p2": "If your application is approved, you will need to enter a purchase agreement within <b>7 days</b>.",
"howToApplyPage.whatHappensNext.title": "What happens next",
"idleTimeout.sessionExpired": "Your session has expired.",
"idleTimeout.sessionInactivity": "To protect your identity, your session will expire in one minute due to inactivity. You will lose any unsaved information you've entered into the application for this listing if you choose not to respond.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -515,12 +515,24 @@ exports[`<HowToApply /> renders HowToApply component 1`] = `
<div
class="pt-4"
>
We will email you your place in line within 2 business days. If anyone applied before you, we review their application(s) first.
<span>
We will email you your place in line within
<b>
2 business days
</b>
. If anyone applied before you, we review their application(s) first.
</span>
</div>
<div
class="py-2"
>
If your application is approved, you will need to enter a purchase agreement within 7 days.
<span>
If your application is approved, you will need to enter a purchase agreement within
<b>
7 days
</b>
.
</span>
</div>
<a
class="underline"
Expand Down
8 changes: 6 additions & 2 deletions app/javascript/pages/how-to-apply/how-to-apply.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,12 @@ const WhatHappensNextSection = () => {
return (
<>
<Header headerText={t("howToApplyPage.whatHappensNext.title")} />
<div className="pt-4">{t("howToApplyPage.whatHappensNext.p1")}</div>
<div className="py-2">{t("howToApplyPage.whatHappensNext.p2")}</div>
<div className="pt-4">
{renderInlineMarkup(t("howToApplyPage.whatHappensNext.p1"), "<b>")}
</div>
<div className="py-2">
{renderInlineMarkup(t("howToApplyPage.whatHappensNext.p2"), "<b>")}
</div>
<a className="underline" target="_blank" href="//google.com">
{t("listings.fcfs.bmrSales.noLotteryRequired.footer")}
</a>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"cssnano": "^6.0.1",
"dayjs": "^1.10.7",
"dotenv": "2.0.0",
"markdown-to-jsx": "7.4.0",
"markdown-to-jsx": "7.4.3",
"mini-css-extract-plugin": "^2.7.6",
"postcss": "^8.4.31",
"postcss-flexbugs-fixes": "^5.0.2",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8547,10 +8547,10 @@ [email protected]:
resolved "https://registry.yarnpkg.com/markdown-to-jsx/-/markdown-to-jsx-7.1.8.tgz#49c3bb3c122aa714324034142c8829b93c889338"
integrity sha512-rRSa1aFmFnpDRFAhv5vIkWM4nPaoB9vnzIjuIKa1wGupfn2hdCNeaQHKpu4/muoc8n8J7yowjTP2oncA4/Rbgg==

[email protected].0:
version "7.4.0"
resolved "https://registry.yarnpkg.com/markdown-to-jsx/-/markdown-to-jsx-7.4.0.tgz#4606c5c549a6f6cb87604c35f5ee4f42959ffb6b"
integrity sha512-zilc+MIkVVXPyTb4iIUTIz9yyqfcWjszGXnwF9K/aiBWcHXFcmdEMTkG01/oQhwSCH7SY1BnG6+ev5BzWmbPrg==
[email protected].3:
version "7.4.3"
resolved "https://registry.yarnpkg.com/markdown-to-jsx/-/markdown-to-jsx-7.4.3.tgz#668c510cb909530f6bdece3d4dc6b41f8b6eceb7"
integrity sha512-qwu2XftKs/SP+f6oCe0ruAFKX6jZaKxrBfDBV4CthqbVbRQwHhNM28QGDQuTldCaOn+hocaqbmGvCuXO5m3smA==

markdown-to-jsx@^6.11.4:
version "6.11.4"
Expand Down

0 comments on commit 64e941f

Please sign in to comment.