Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAH-1718: Error accessibility #1963

Merged
merged 2 commits into from
Oct 10, 2023
Merged

DAH-1718: Error accessibility #1963

merged 2 commits into from
Oct 10, 2023

Conversation

cliu02
Copy link
Collaborator

@cliu02 cliu02 commented Oct 10, 2023 •
edited by jira bot
Loading

@cliu02 cliu02 added the needs review Pull request needs review label Oct 10, 2023
@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-1963 October 10, 2023 21:52 Inactive
@cliu02 cliu02 temporarily deployed to dahlia-webapp-pr-1963 October 10, 2023 22:15 Inactive
@cade-exygy cade-exygy self-requested a review October 10, 2023 22:54
cade-exygy
cade-exygy approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@cade-exygy cade-exygy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Using JAWS, I can hear the screen reader read the field errors when the field is activated.

@cliu02 cliu02 merged commit e6725e2 into main Oct 10, 2023
1 check passed
@cliu02 cliu02 deleted the DAH-1718-error-accessibility branch October 10, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cade-exygy cade-exygy cade-exygy approved these changes

Assignees
No one assigned
Labels
needs review Pull request needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cliu02 @cade-exygy @hshaosf