DAH-2630 SCV Lottery Modal General Pool Section

[jimlin-sfgov]

Description

In the SCV-specific lottery modal, move the 'General Pool' section to be nested under the 'General Public' section.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-2630

Checklist before requesting review

Version Control

• branch name begins with angular if it contains updates to Angular code
• branch name contains the Jira ticket number
• PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

• the set of changes is small
• if the set of changes cannot be small, reviewers have been forewarned
• code meets test coverage thresholds
• code is properly formatted
• code is linted
• code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
• automated tests pass
• if the code changes the UI, it matches the UI design exactly

Review instructions

• instructions specify which environment(s) it applies to
• instructions have already been performed at least once
• instructions can be followed by PA testers
• instructions specify if it can only be followed by an engineer

Request review

• PR has needs review label
• Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
• If time sensitive, notify engineers in Slack

[cliu02]

LGTM!