Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-2667 update how feature flag is called so live updating works #2288

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

tallulahkay
Copy link
Contributor

@tallulahkay tallulahkay commented Sep 9, 2024

Description

Update feature flags in rails so that behavior changes when feature flag is changed after deployment.

Jira ticket

DAH-2667

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions have already been performed at least once
  • instructions can be followed by PA testers
  • instructions specify if it can only be followed by an engineer

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2288 September 9, 2024 18:48 Inactive
@tallulahkay tallulahkay requested review from cade-exygy, josh-chou, a team and cliu02 and removed request for josh-chou and a team September 9, 2024 18:58
@tallulahkay tallulahkay added the needs review Pull request needs review label Sep 9, 2024
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2288 September 10, 2024 19:44 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2288 September 10, 2024 23:44 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2288 September 12, 2024 15:26 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2288 September 12, 2024 19:45 Inactive
Copy link
Collaborator

@cliu02 cliu02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2288 September 12, 2024 23:10 Inactive
@tallulahkay tallulahkay merged commit a11117e into main Sep 13, 2024
18 checks passed
@tallulahkay tallulahkay deleted the DAH-2667-rails-ff-live-update branch September 13, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants